From: Jakub Jelinek <jakub@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>,
gcc@gcc.gnu.org, Joel Brobecker <brobecker@adacore.com>
Subject: Re: gcc-cvs mails for personal/vendor branches for merge commits
Date: Wed, 15 Jan 2020 15:51:00 -0000 [thread overview]
Message-ID: <20200115150109.GU10088@tucnak> (raw)
In-Reply-To: <alpine.DEB.2.21.2001151448060.11538@digraph.polyomino.org.uk>
On Wed, Jan 15, 2020 at 02:56:45PM +0000, Joseph Myers wrote:
> > As I said on IRC, I have done on our vendor branch redhat/gcc-10-branch
> > a simple
> > git merge r10-5981-ga52d93219c63d38fa9a97d0eb727e7fcc935e9b3
> > git push origin redhat/gcc-10-branch:refs/vendors/redhat/heads/gcc-10-branch
> > which merged in just a few hours from trunk, but that resulted in
> > 20 separate mails to gcc-cvs ml.
>
> Joel, this is definitely a question for you; it's beyond my expertise in
> the working of the hooks. The issue is that when a merge commit is
> pushed, we only want mails for commits that are new *to the repository* -
> not those that are already in the repository (accessible from some other
> ref before the ref update being processed by the hook comes into effect),
> but are new *to the branch*.
Yeah. For release branches I think we want mails for all changes, but
then we don't allow merge commits there; for cherry-picked patches e.g. from
trunk to release branches we should still send mail.
> I think there's a similar issue not just for merges but for
> non-fast-forward pushes as well. As a glibc example, consider
> <https://sourceware.org/ml/glibc-cvs/2019-q4/msg00666.html> and the long
> series of subsequent mails in the glibc-cvs archives. It's correct that
> the five or so rebased patches on the branch got mailed out again. It's
> *not* desirable that the 50 or so patches that were already on master,
> that the branch got rebased on top of, got mailed out again.
Jakub
next prev parent reply other threads:[~2020-01-15 15:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 15:07 Jakub Jelinek
2020-01-15 15:42 ` Joseph Myers
2020-01-15 15:51 ` Jakub Jelinek [this message]
2020-01-15 16:01 ` Joseph Myers
2020-01-15 16:42 ` Jason Merrill
2020-01-15 16:58 ` Joseph Myers
2020-01-15 17:09 ` Jason Merrill
2020-01-15 17:57 ` Iain Sandoe
2020-01-15 20:20 ` Jason Merrill
2020-01-19 14:10 ` Segher Boessenkool
2020-01-19 22:40 ` Julien "_FrnchFrgg_" Rivaud
2020-01-20 18:42 ` Segher Boessenkool
2020-01-15 19:21 ` Richard Earnshaw (lists)
2020-01-16 9:55 ` Joseph Myers
2020-01-16 14:28 ` Joel Brobecker
2020-01-16 14:35 ` Jakub Jelinek
2020-01-16 14:43 ` Richard Earnshaw (lists)
2020-01-16 18:51 ` Jakub Jelinek
2020-01-16 22:03 ` Joseph Myers
2020-01-16 18:58 ` Joseph Myers
2020-01-17 16:47 ` Joel Brobecker
2020-01-17 17:22 ` Iain Sandoe
2020-01-17 17:59 ` Joel Brobecker
2020-01-17 19:15 ` Jason Merrill
2020-01-17 22:39 ` Joel Brobecker
2020-01-18 9:50 ` Iain Sandoe
2020-01-18 11:07 ` Jason Merrill
2020-01-18 14:30 ` Joseph Myers
2020-01-17 17:23 ` Joseph Myers
2020-01-17 21:14 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115150109.GU10088@tucnak \
--to=jakub@redhat.com \
--cc=Richard.Earnshaw@arm.com \
--cc=brobecker@adacore.com \
--cc=gcc@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).