From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: joseph@codesourcery.com (Joseph Myers)
Cc: gcc@gcc.gnu.org
Subject: Re: fast_math_flags_set_p vs. set_fast_math_flags inconsistency?
Date: Thu, 30 Jan 2020 12:33:00 -0000 [thread overview]
Message-ID: <20200129095205.EF669D80316@oc3748833570.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2001282141420.22424@digraph.polyomino.org.uk> from "Joseph Myers" at Jan 28, 2020 09:42:11 PM
Joseph Myers wrote:
> On Tue, 28 Jan 2020, Ulrich Weigand wrote:
>
> > The following patch (not yet fully tested) implements the above changes.
> > Note that this now brings the set of flags set and reset by
> > set_fast_math_flags completely in sync with the set of flags
> > tested in fast_math_flags_set_p.
> >
> > Does this make sense to you?
>
> It makes sense, but this is not a review of the patch.
Understood, thanks for having a look! I'll go ahead and submit the
patch for review as usual then.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2020-01-29 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 14:52 Ulrich Weigand
2020-01-21 15:05 ` Joseph Myers
2020-01-21 15:39 ` Ulrich Weigand
2020-01-21 18:50 ` Joseph Myers
2020-01-28 15:55 ` Ulrich Weigand
2020-01-28 17:19 ` Joseph Myers
2020-01-30 5:44 ` Ulrich Weigand
2020-01-30 10:00 ` Joseph Myers
2020-01-30 12:33 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129095205.EF669D80316@oc3748833570.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gcc@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).