public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* GCC 8.4 Status Report (2020-02-17)
@ 2020-02-17 10:45 Jakub Jelinek
  2020-02-23 18:25 ` Thomas Backlund
  0 siblings, 1 reply; 6+ messages in thread
From: Jakub Jelinek @ 2020-02-17 10:45 UTC (permalink / raw)
  To: gcc; +Cc: Jason Merrill, Matthias Klose

Status
======

It has been almost a year since GCC 8.3 has been released and GCC 8.4
release should have been released already, so we should concentrate on
getting it out soon.  Unfortunately we have two P1s, one of them is
waiting for reporter's input, so we might as well just ignore it unless
the input is provided, but the other, C++ FE one, looks something that
should be fixed.  If we get rid of the P1s, I'd like to create
8.4-rc1 on Wednesday, Feb 26th and release 8.4 the week afterwards.
If you have any queued backports, please commit them to 8 branch
(and 9 branch too, we'd like to release 9.3 soon too).


Quality Data
============

Priority          #   Change from last report
--------        ---   -----------------------
P1                2   +   2
P2              284   +  75
P3               38   +   4
P4              151   -  11
P5               22   -   2
--------        ---   -----------------------
Total P1-P3     324   +  81
Total           497   +  68


Previous Report
===============

https://gcc.gnu.org/ml/gcc/2019-02/msg00122.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: GCC 8.4 Status Report (2020-02-17)
  2020-02-17 10:45 GCC 8.4 Status Report (2020-02-17) Jakub Jelinek
@ 2020-02-23 18:25 ` Thomas Backlund
  2020-02-23 20:44   ` Jakub Jelinek
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Backlund @ 2020-02-23 18:25 UTC (permalink / raw)
  To: Jakub Jelinek, gcc; +Cc: Jason Merrill, Matthias Klose

Den 17-02-2020 kl. 12:45, skrev Jakub Jelinek:
> Status
> ======
> 
> It has been almost a year since GCC 8.3 has been released and GCC 8.4
> release should have been released already, so we should concentrate on
> getting it out soon.  Unfortunately we have two P1s, one of them is
> waiting for reporter's input, so we might as well just ignore it unless
> the input is provided, but the other, C++ FE one, looks something that
> should be fixed.  If we get rid of the P1s, I'd like to create
> 8.4-rc1 on Wednesday, Feb 26th and release 8.4 the week afterwards.
> If you have any queued backports, please commit them to 8 branch
> (and 9 branch too, we'd like to release 9.3 soon too).
> 
> 
> Quality Data
> ============
> 
> Priority          #   Change from last report
> --------        ---   -----------------------
> P1                2   +   2
> P2              284   +  75
> P3               38   +   4
> P4              151   -  11
> P5               22   -   2
> --------        ---   -----------------------
> Total P1-P3     324   +  81
> Total           497   +  68
> 
> 
> Previous Report
> ===============
> 
> https://gcc.gnu.org/ml/gcc/2019-02/msg00122.html
> 
> 

Can this one be backported to  gcc 8.4:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521

It fixes errors like:
https://travis-ci.org/akien-mga/godot/jobs/654085724
----
./core/math/vector3.h:40:8: note: candidate: 'constexpr 
Vector3::Vector3(Vector3&&)'

editor/plugins/path_editor_plugin.cpp:214:176: error: call of overloaded 
'Vector3(const Variant&)' is ambiguous
----

The same code builds ok with gcc-7 and gcc-9

And the fix is confirmed with that fix backported on top of gcc-8-20200221

--
Thomas


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: GCC 8.4 Status Report (2020-02-17)
  2020-02-23 18:25 ` Thomas Backlund
@ 2020-02-23 20:44   ` Jakub Jelinek
  0 siblings, 0 replies; 6+ messages in thread
From: Jakub Jelinek @ 2020-02-23 20:44 UTC (permalink / raw)
  To: Thomas Backlund; +Cc: gcc, Jason Merrill, Matthias Klose

On Sun, Feb 23, 2020 at 08:25:32PM +0200, Thomas Backlund wrote:
> Can this one be backported to  gcc 8.4:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521
> 
> It fixes errors like:
> https://travis-ci.org/akien-mga/godot/jobs/654085724
> ----
> ./core/math/vector3.h:40:8: note: candidate: 'constexpr
> Vector3::Vector3(Vector3&&)'
> 
> editor/plugins/path_editor_plugin.cpp:214:176: error: call of overloaded
> 'Vector3(const Variant&)' is ambiguous
> ----
> 
> The same code builds ok with gcc-7 and gcc-9
> 
> And the fix is confirmed with that fix backported on top of gcc-8-20200221

I'll defer that to Jason, it depends on whether the benefits of the
backport outweight the risks and whether it had any follow-ups that would
need to be backported too.

	Jakub

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: GCC 8.4 Status Report (2020-02-17)
  2020-02-19  9:24 ` Richard Biener
@ 2020-02-20 13:23   ` Bernd Edlinger
  0 siblings, 0 replies; 6+ messages in thread
From: Bernd Edlinger @ 2020-02-20 13:23 UTC (permalink / raw)
  To: Richard Biener; +Cc: Jakub Jelinek, gcc, Jason Merrill, Matthias Klose

On 2/19/20 10:24 AM, Richard Biener wrote:
> On Tue, Feb 18, 2020 at 8:37 PM Bernd Edlinger
> <bernd.edlinger@hotmail.de> wrote:
>>
>>> It has been almost a year since GCC 8.3 has been released and GCC 8.4
>>> release should have been released already, so we should concentrate on
>>> getting it out soon.  Unfortunately we have two P1s, one of them is
>>> waiting for reporter's input, so we might as well just ignore it unless
>>> the input is provided, but the other, C++ FE one, looks something that
>>> should be fixed.  If we get rid of the P1s, I'd like to create
>>> 8.4-rc1 on Wednesday, Feb 26th and release 8.4 the week afterwards.
>>> If you have any queued backports, please commit them to 8 branch
>>> (and 9 branch too, we'd like to release 9.3 soon too).
>>
>> Hi Jakub,
>>
>> it just occurred to me that my patch here is a kind of
>> security relevant one:
>>
>> https://gcc.gnu.org/ml/gcc-patches/2020-02/msg01060.html
>>
>> since every time the collect2 process is interrupted via a signal
>> it can delete random files from the hard drive, since the
>> signal handler may be using the path name, and passes it to the unlink
>> function before it is initialized.
>>
>> The patch doe not apply cleanly to gcc-8, but just fixing
>> that issue, without tackling the cleanup at the same time should
>> be feasible, if you like that for this version?
> 
> Sure, these kind of fixes are always welcome, but please  post them
> for review.
> 

OK, posted here:
https://gcc.gnu.org/ml/gcc-patches/2020-02/msg01104.html

Bernd.

> Richard.
> 
>>
>> Thanks
>> Bernd.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: GCC 8.4 Status Report (2020-02-17)
  2020-02-18 19:37 Bernd Edlinger
@ 2020-02-19  9:24 ` Richard Biener
  2020-02-20 13:23   ` Bernd Edlinger
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Biener @ 2020-02-19  9:24 UTC (permalink / raw)
  To: Bernd Edlinger; +Cc: Jakub Jelinek, gcc, Jason Merrill, Matthias Klose

On Tue, Feb 18, 2020 at 8:37 PM Bernd Edlinger
<bernd.edlinger@hotmail.de> wrote:
>
> > It has been almost a year since GCC 8.3 has been released and GCC 8.4
> > release should have been released already, so we should concentrate on
> > getting it out soon.  Unfortunately we have two P1s, one of them is
> > waiting for reporter's input, so we might as well just ignore it unless
> > the input is provided, but the other, C++ FE one, looks something that
> > should be fixed.  If we get rid of the P1s, I'd like to create
> > 8.4-rc1 on Wednesday, Feb 26th and release 8.4 the week afterwards.
> > If you have any queued backports, please commit them to 8 branch
> > (and 9 branch too, we'd like to release 9.3 soon too).
>
> Hi Jakub,
>
> it just occurred to me that my patch here is a kind of
> security relevant one:
>
> https://gcc.gnu.org/ml/gcc-patches/2020-02/msg01060.html
>
> since every time the collect2 process is interrupted via a signal
> it can delete random files from the hard drive, since the
> signal handler may be using the path name, and passes it to the unlink
> function before it is initialized.
>
> The patch doe not apply cleanly to gcc-8, but just fixing
> that issue, without tackling the cleanup at the same time should
> be feasible, if you like that for this version?

Sure, these kind of fixes are always welcome, but please  post them
for review.

Richard.

>
> Thanks
> Bernd.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: GCC 8.4 Status Report (2020-02-17)
@ 2020-02-18 19:37 Bernd Edlinger
  2020-02-19  9:24 ` Richard Biener
  0 siblings, 1 reply; 6+ messages in thread
From: Bernd Edlinger @ 2020-02-18 19:37 UTC (permalink / raw)
  To: Jakub Jelinek, gcc; +Cc: Jason Merrill, Matthias Klose

> It has been almost a year since GCC 8.3 has been released and GCC 8.4
> release should have been released already, so we should concentrate on
> getting it out soon.  Unfortunately we have two P1s, one of them is
> waiting for reporter's input, so we might as well just ignore it unless
> the input is provided, but the other, C++ FE one, looks something that
> should be fixed.  If we get rid of the P1s, I'd like to create
> 8.4-rc1 on Wednesday, Feb 26th and release 8.4 the week afterwards.
> If you have any queued backports, please commit them to 8 branch
> (and 9 branch too, we'd like to release 9.3 soon too).

Hi Jakub,

it just occurred to me that my patch here is a kind of
security relevant one:

https://gcc.gnu.org/ml/gcc-patches/2020-02/msg01060.html

since every time the collect2 process is interrupted via a signal
it can delete random files from the hard drive, since the
signal handler may be using the path name, and passes it to the unlink
function before it is initialized.

The patch doe not apply cleanly to gcc-8, but just fixing
that issue, without tackling the cleanup at the same time should
be feasible, if you like that for this version?


Thanks
Bernd.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-02-23 20:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-17 10:45 GCC 8.4 Status Report (2020-02-17) Jakub Jelinek
2020-02-23 18:25 ` Thomas Backlund
2020-02-23 20:44   ` Jakub Jelinek
2020-02-18 19:37 Bernd Edlinger
2020-02-19  9:24 ` Richard Biener
2020-02-20 13:23   ` Bernd Edlinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).