public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: Rainer Orth <ro@cebitec.uni-bielefeld.de>,
	Richard Biener <rguenther@suse.de>,
	gcc@gcc.gnu.org
Subject: Re: gcc/DATESTAMP not updated any longer
Date: Mon, 2 Nov 2020 21:58:49 +0100	[thread overview]
Message-ID: <20201102205849.GL3788@tucnak> (raw)
In-Reply-To: <30cf614e-814a-aa3f-b31f-91f6104b833a@suse.cz>

On Mon, Nov 02, 2020 at 09:37:56PM +0100, Martin Liška wrote:
> > writing to ./gcc/testsuite/ChangeLog
> > empty group "()" found:"	* tree-vect-slp.c (): Update backedges in single-node cycles."
> > Traceback (most recent call last):
> >    File "../gcc-changelog/git_update_version.py", line 143, in <module>
> >      update_current_branch()
> >    File "../gcc-changelog/git_update_version.py", line 103, in update_current_branch
> >      not args.dry_mode)
> >    File "../gcc-changelog/git_update_version.py", line 39, in prepend_to_changelog_files
> >      raise AssertionError()
> > AssertionError
> > 
> > That's the Richard's commit that slipped through the verification, but
> > upsets ChangeLog generation.
> 
> Whoops! Sorry for that.
> 
> Please run the script manually with the following patch:
> 
> diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py
> index 1d0860cddd8..70cd2c5c2b3 100755
> --- a/contrib/gcc-changelog/git_commit.py
> +++ b/contrib/gcc-changelog/git_commit.py
> @@ -465,7 +465,7 @@ class GitCommit:
>                                  for needle in ('()', '[]', '<>'):
>                                      if ' ' + needle in parts[0]:
>                                          msg = f'empty group "{needle}" found'
> -                                        self.errors.append(Error(msg, line))
> +                                        # self.errors.append(Error(msg, line))
>                              last_entry.lines.append(line)
>                      else:
>                          if last_entry.is_empty:
> 
> Then all should be fine as new error should not appear.

It isn't that easy (because update_version_git checks the gcc trunk and
so I had to insert a sh invocation in which I've tweaked it), but it worked,
thanks.  But something is really wrong with the hooks, as the gcc-cvs mail
for the trunk daily bump wasn't sent again (r10, r9 and r8 changes did).

	Jakub


  reply	other threads:[~2020-11-02 20:58 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 19:14 Rainer Orth
2020-11-02 19:43 ` Jakub Jelinek
2020-11-02 20:37   ` Martin Liška
2020-11-02 20:58     ` Jakub Jelinek [this message]
2020-11-03 18:26       ` Joseph Myers
2020-11-06 19:45         ` Jakub Jelinek
2020-11-06 19:56           ` Richard Biener
2020-11-06 19:59             ` Jakub Jelinek
2020-11-06 20:08               ` Iain Sandoe
2020-11-08  9:55                 ` Iain Sandoe
2020-11-09  7:57               ` Martin Liška
2020-11-09 22:09                 ` Jakub Jelinek
2020-11-10  8:23                   ` Martin Liška
2020-11-13  9:57                     ` Jakub Jelinek
2020-12-11 13:17 ` Rainer Orth
2020-12-11 18:04   ` Martin Liška
2020-12-11 18:26     ` Jakub Jelinek
2020-12-14  8:59       ` Martin Liška
2020-12-14  9:05         ` Jakub Jelinek
2020-12-14  9:21           ` Martin Liška
2020-12-14  9:23             ` Jakub Jelinek
2020-12-14  9:32               ` Martin Liška
2020-12-14 10:02         ` Andreas Schwab
2020-12-14 10:18           ` Jakub Jelinek
2020-12-15  0:04         ` Joseph Myers
2020-12-14 23:58     ` Joseph Myers
2020-12-15  8:30       ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102205849.GL3788@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc@gcc.gnu.org \
    --cc=mliska@suse.cz \
    --cc=rguenther@suse.de \
    --cc=ro@cebitec.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).