From: Peter Zijlstra <peterz@infradead.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
Uros Bizjak <ubizjak@gmail.com>,
GCC Development <gcc@gcc.gnu.org>, X86 ML <x86@kernel.org>,
Jakub Jelinek <jakub@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
linux-toolchains@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Will Deacon <will@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: typeof and operands in named address spaces
Date: Tue, 10 Nov 2020 08:57:42 +0100 [thread overview]
Message-ID: <20201110075742.GT2594@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKwvOd=pBBNnGmQ0q-RHBZaVZ-npUFDOdjcA_7+f_zaF0XseuA@mail.gmail.com>
On Mon, Nov 09, 2020 at 11:50:15AM -0800, Nick Desaulniers wrote:
> On Mon, Nov 9, 2020 at 11:46 AM Segher Boessenkool
> <segher@kernel.crashing.org> wrote:
> >
> > On Mon, Nov 09, 2020 at 01:47:13PM +0100, Peter Zijlstra wrote:
> > >
> > > + lots of people and linux-toolchains
> > >
> > > On Wed, Nov 04, 2020 at 07:31:42PM +0100, Uros Bizjak wrote:
> > > > Hello!
> > > >
> > > > I was looking at the recent linux patch series [1] where segment
> > > > qualifiers (named address spaces) were introduced to handle percpu
> > > > variables. In the patch [2], the author mentions that:
> > > >
> > > > --q--
> > > > Unfortunately, gcc does not provide a way to remove segment
> > > > qualifiers, which is needed to use typeof() to create local instances
> > > > of the per-cpu variable. For this reason, do not use the segment
> > > > qualifier for per-cpu variables, and do casting using the segment
> > > > qualifier instead.
> > > > --/q--
> > >
> > > C in general does not provide means to strip qualifiers.
> >
> > Most ways you can try to use the result are undefined behaviour, even.
>
> Yes, removing `const` from a `const` declared variable (via cast) then
> expecting to use the result is a great way to have clang omit the use
> from the final program. This has bitten us in the past getting MIPS
> support up and running, and one of the MTK gfx drivers.
Stripping const to delcare another variable is useful though. Sure C has
sharp edges, esp. if you cast stuff, but since when did that stop anyone
;-)
The point is, C++ has these very nice template helpers that can strip
qualifiers, I want that too, for much of the same reasons. We might not
have templates :-(, but we've become very creative with our
pre-processor.
Surely our __unqual_scalar_typeof() cries for a better solution.
next prev parent reply other threads:[~2020-11-10 7:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 18:31 Uros Bizjak
2020-11-05 7:26 ` Richard Biener
2020-11-05 8:56 ` Uros Bizjak
2020-11-05 9:36 ` Alexander Monakov
2020-11-05 10:33 ` Uros Bizjak
2020-11-05 11:38 ` Alexander Monakov
2020-11-05 12:00 ` Uros Bizjak
2020-11-05 12:14 ` Alexander Monakov
2020-11-05 12:24 ` Richard Biener
2020-11-05 12:32 ` Uros Bizjak
2020-11-05 12:35 ` Uros Bizjak
2020-11-05 13:22 ` Alexander Monakov
2020-11-05 13:39 ` Alexander Monakov
2020-11-05 13:46 ` Uros Bizjak
2020-11-05 12:26 ` Uros Bizjak
2020-11-05 15:27 ` Andy Lutomirski
2020-11-05 11:03 ` Uros Bizjak
2020-11-05 9:45 ` Richard Biener
2020-11-05 9:51 ` Jakub Jelinek
2020-11-09 12:47 ` Peter Zijlstra
2020-11-09 19:38 ` Segher Boessenkool
2020-11-09 19:50 ` Nick Desaulniers
2020-11-10 7:57 ` Peter Zijlstra [this message]
2020-11-10 18:42 ` Nick Desaulniers
2020-11-10 20:11 ` Peter Zijlstra
2020-11-12 0:40 ` Segher Boessenkool
2020-11-12 0:47 ` Segher Boessenkool
2020-11-10 7:52 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110075742.GT2594@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=borntraeger@de.ibm.com \
--cc=gcc@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=linux-toolchains@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mpe@ellerman.id.au \
--cc=ndesaulniers@google.com \
--cc=segher@kernel.crashing.org \
--cc=torvalds@linux-foundation.org \
--cc=ubizjak@gmail.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).