From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by sourceware.org (Postfix) with ESMTPS id A2120383800B for ; Mon, 26 Apr 2021 18:00:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A2120383800B IronPort-SDR: aiUXS5B7usY5wmBx03Ufapt0G6P7jmIpL4f5mJqJ/fUQ+Dy51jSrbPJ6QZaMsTWLofnQjaM+vp kBk3fCUXgYOA== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="176496283" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="176496283" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 11:00:15 -0700 IronPort-SDR: u63991odWdakuJY401UXnblNpOsGyLE/7bfz9qbNv7+T8FCj3CySVKHwUIQnMDPCiraIbW6/mj nfrYnWEBqRFA== X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="422744657" Received: from tassilo.jf.intel.com ([10.54.74.11]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 11:00:12 -0700 Date: Mon, 26 Apr 2021 11:00:11 -0700 From: Andi Kleen To: Xinliang David Li Cc: Jan Hubicka , "gcc@gcc.gnu.org" , Wei Mi , Eugene Rozenfeld Subject: Re: State of AutoFDO in GCC Message-ID: <20210426180011.GA1401198@tassilo.jf.intel.com> References: <20210423165449.GC56452@kam.mff.cuni.cz> <20210423171611.GA82007@kam.mff.cuni.cz> <20210423192834.GA1949@kam.mff.cuni.cz> <20210425190754.GA88857@kam.mff.cuni.cz> <87a6plulkz.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2021 18:00:18 -0000 > There are multiple directional changes in this new tool: > 1) it uses perf-script trace output (in text) as input profile data;  I suspect this will break regularly too (I personally did numerous changes to perf script output, and also wrote a lot of parsing scripts) The perf script output has some bad problems, e.g. for file names or processes with spaces and some other issues. To make it handleable would need some redesign to actually generate in a machine friendly format. A perf.data parser should be fine, just don't fill it up with asserts and "be liberal what you accept" and ignore unknown records. -Andi