From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 2A8353865C2D for ; Thu, 10 Jun 2021 17:30:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A8353865C2D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-558-olUiO332ODyVjCrmNmPmwg-1; Thu, 10 Jun 2021 13:30:11 -0400 X-MC-Unique: olUiO332ODyVjCrmNmPmwg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DDD71100CA97; Thu, 10 Jun 2021 17:30:10 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-114-102.ams2.redhat.com [10.36.114.102]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6C4919CA8; Thu, 10 Jun 2021 17:30:08 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 15AHU6Rk2303889 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Jun 2021 19:30:06 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 15AHU5hm2303888; Thu, 10 Jun 2021 19:30:05 +0200 Date: Thu, 10 Jun 2021 19:30:05 +0200 From: Jakub Jelinek To: Martin Sebor Cc: Jonathan Wakely , gcc@gcc.gnu.org Subject: Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog Message-ID: <20210610173005.GI7746@tucnak> Reply-To: Jakub Jelinek References: <36a4f5c4-357a-ca1c-e7f5-ede6ff3ba445@suse.cz> <20210610100851.GD7746@tucnak> <1230cb99-ed83-3e4e-8362-94f03ee021bc@gmail.com> <3228435b-aba0-6157-3266-c0f025822829@gmail.com> <5f89ddc0-aed4-2c20-0979-dfafb29046ee@gmail.com> MIME-Version: 1.0 In-Reply-To: <5f89ddc0-aed4-2c20-0979-dfafb29046ee@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2021 17:30:14 -0000 On Thu, Jun 10, 2021 at 11:20:26AM -0600, Martin Sebor wrote: > One other note: you mention policy above, which suggests a requirement. > My understanding is that the format of a commit message is a convention > put in place to take some of the tedium out of creating ChangeLog > entries. If that's still correct, I would be more in favor of making > the Git commit hook smarter and more forgiving than of adding new > requirements imposing a more rigid format. It is a requirement (perhaps badly worded) which has been there since January last year. And it is a good idea that the PR number if any and some category shows up in git shortlog listing too. > Recognizing a PRnnnnn anywhere within the commit message and "doing > the thing" rather than rejecting a commit if it doesn't have a PRnnnn > on the first line (but does somewhere else) would be a change I'd vote > for. The text above the by the script recognized ChangeLog entry, except for the first line which is treated by git specially, is free text, it could mention various PRs but doesn't actually mean that they were fixed, just perhaps in some way related etc. Furthermore, for commits that fixed PRs we want those PR numbers be in the ChangeLog files too. Jakub