From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 89DC03855006 for ; Fri, 11 Jun 2021 20:36:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 89DC03855006 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-514--NVWO59vNK-XF_f6uGaFwg-1; Fri, 11 Jun 2021 16:36:02 -0400 X-MC-Unique: -NVWO59vNK-XF_f6uGaFwg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2C4F7803627; Fri, 11 Jun 2021 20:36:01 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-114-102.ams2.redhat.com [10.36.114.102]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B708D60C05; Fri, 11 Jun 2021 20:36:00 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 15BKZwwt580958 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 11 Jun 2021 22:35:58 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 15BKZvPI580957; Fri, 11 Jun 2021 22:35:57 +0200 Date: Fri, 11 Jun 2021 22:35:57 +0200 From: Jakub Jelinek To: Jason Merrill Cc: Markus Faehling , gcc@gcc.gnu.org Subject: Re: GCC/clang warning incompatibility with unused private member variables Message-ID: <20210611203557.GX7746@tucnak> Reply-To: Jakub Jelinek References: <5f5ddb1f-39f7-d858-e1c5-afff73043df3@faehling.com> <7aa76520-3250-1bda-9fd9-baee1e83cd44@redhat.com> MIME-Version: 1.0 In-Reply-To: <7aa76520-3250-1bda-9fd9-baee1e83cd44@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 20:36:05 -0000 On Fri, Jun 11, 2021 at 04:03:34PM -0400, Jason Merrill via Gcc wrote: > You can use #pragma to disable a warning for a particular section of code: > > #pragma GCC diagnostic push > #pragma GCC diagnostic ignored "-Wattributes" > class Test { > [[maybe_unused]] int a_; > void b() {}; > }; > #pragma GCC diagnostic pop > > But I also agree that GCC shouldn't warn here. We could do that by using a wrapper around handle_unused_attribute for the maybe_unused attribute, that way warn on unused attribute on FIELD_DECLs, but not for maybe_unused (until we actually implement some warning that uses it). Jakub