Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

[Jakub Jelinek <jakub@redhat.com>]

On Fri, Jun 18, 2021 at 12:10:33PM +0100, Jonathan Wakely wrote:
> On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote:
> > But with -p added, it becomes rather nice. For instance:
> >
> >    git diff |./contrib/mklog.py -b foo/12394 -b 100123 -p
> >
> > nows prints:
> >
> > PR c++/12394 - internal compiler error: in write_type, at cp/mangle.c:1517
> > PR fortran/100123 - -ftree-fre gives incorrect result in subroutine with array declared as length 1
> >
> >          PR c++/12394
> >          PR fortran/100123
> 
> Now that we put these PR cmpt/nnnn lines before the xxx/ChangeLog
> entries, is there any reason to indent them with a TAB?

We want those PR lines in the ChangeLogs to be indented by the tab,
only the date line is not indented.

I agree it would be nice to allow again optional space hyphen space description
after the PR component/nnnnnn and it is also pitty we don't allow anymore
what used to be common in the gcc/cp ChangeLog for C++ papers.
That used to be either written after the PR, or without it:
	PR c++/88337 - Implement P1327R1: Allow dynamic_cast in constexpr.
	PR c++/91353 - P1331R2: Allow trivial default init in constexpr contexts.
	Implement P1814R0, CTAD for alias templates.
	P1381R1 - Reference capture of structured bindings
not sure if we want to allow arbitrary text there, but perhaps allow
"^\tP[0-9]+R[0-9]+ - .*"
in addition to that optional
"^\tPR ([^/]+)/\d+ - .*"
?

	Jakub