From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jbglaw@lug-owl.de>
Received: from lug-owl.de (lug-owl.de [IPv6:2a03:4000:10:469::])
 by sourceware.org (Postfix) with ESMTP id C3F9C3858C39
 for <gcc@gcc.gnu.org>; Wed, 15 Sep 2021 18:34:21 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C3F9C3858C39
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=lug-owl.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lug-owl.de
Received: by lug-owl.de (Postfix, from userid 1001)
 id DB69641F01; Wed, 15 Sep 2021 20:34:20 +0200 (CEST)
Date: Wed, 15 Sep 2021 20:34:20 +0200
From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Mark Wielaard <mark@klomp.org>
Cc: Jonathan Wakely <jwakely.gcc@gmail.com>,
 Thomas Koenig <tkoenig@netcologne.de>, gcc mailing list <gcc@gcc.gnu.org>
Subject: Re: Error when accessing git read-only archive
Message-ID: <20210915183420.3g2jujfalm47qz2f@lug-owl.de>
References: <8fe140f6-804b-0180-e4d3-5293ee11905c@netcologne.de>
 <CAH6eHdQPppiZmtPqrfWgJ3wLzFm2_deYDegx7y4G89D7oKe6iw@mail.gmail.com>
 <CAH6eHdRFKEdha2W50UbaJMSWHXHHqyUn6iynLPxk-rAw-uPCKQ@mail.gmail.com>
 <3d642e058b5fde27ec3dd955183a3b2de934174c.camel@redhat.com>
 <20210915133710.agtw4l4vwjo6myhm@lug-owl.de>
 <CAH6eHdQH_Csm4n045bmAXh8S2JyQCQM-=1FPOdh0gw3Y_JD3gw@mail.gmail.com>
 <6162616e4f65918c17509b3afacfd24b23532ce8.camel@klomp.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="vhb6qntgdyybigno"
Content-Disposition: inline
In-Reply-To: <6162616e4f65918c17509b3afacfd24b23532ce8.camel@klomp.org>
X-Operating-System: Linux chamaeleon 5.8.0-0.bpo.2-amd64 
X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444  A961 1DBD 5E75 8399 E1BB
X-gpg-key: wwwkeys.de.pgp.net
X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear
 warfare test the bombastical terror of flooding the spy
 listeners explosion sex drugs and rock'n'roll
X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare
 test the bombastical terror of flooding the spy listeners explosion sex
 drugs and rock'n'roll
X-message-flag: Please send plain text messages only. Do not send HTML
 emails. Thank you. 
User-Agent: NeoMutt/20170113 (1.7.2)
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc mailing list <gcc.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc>,
 <mailto:gcc-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <mailto:gcc-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc>,
 <mailto:gcc-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Sep 2021 18:34:25 -0000


--vhb6qntgdyybigno
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, 2021-09-15 16:10:50 +0200, Mark Wielaard <mark@klomp.org> wrote:
[UTF-8 email address containing a '=C5=82']
> The issue is the gravatar support, which calls md5_hex($email).
> For now I disabled gravatar support on sourceware.org/gcc.gnu.org in
> /etc/gitweb.conf

I am not a Perl guy, but it seems this works (tested locally):


--- a/gitweb/gitweb.perl	2021-09-15 20:23:13.788195846 +0200
+++ b/gitweb/gitweb.perl	2021-09-15 20:24:19.911806868 +0200
@@ -2193,7 +2193,7 @@
 	my $size =3D shift;
 	$avatar_cache{$email} ||=3D
 		"//www.gravatar.com/avatar/" .
-			md5_hex($email) . "?s=3D";
+			md5_hex(utf8::is_utf8($email)? Encode::encode_utf8($email): $email) . "=
?s=3D";
 	return $avatar_cache{$email} . $size;
 }
=20

I'll send that to the GIT mailing list and ask for verification.

Thanks,
  Jan-Benedict

--=20

--vhb6qntgdyybigno
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCYUI8qgAKCRAdvV51g5nh
u7D0AJ4pG4busJRzj/KuwVGKS1fD3AJk5gCfWTLIVBfQayZhPyLhwQcM5ESBPt0=
=EahA
-----END PGP SIGNATURE-----

--vhb6qntgdyybigno--