From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3B407385800E for ; Fri, 11 Feb 2022 10:59:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3B407385800E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-395-2jkBJloyM2uBU5dS0I0T2Q-1; Fri, 11 Feb 2022 05:59:21 -0500 X-MC-Unique: 2jkBJloyM2uBU5dS0I0T2Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5EA40102C87E; Fri, 11 Feb 2022 10:59:16 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.125]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D3BD87D70F; Fri, 11 Feb 2022 10:59:15 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 21BAxCLb2432478 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 11 Feb 2022 11:59:13 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 21BAxBGv2432477; Fri, 11 Feb 2022 11:59:11 +0100 Date: Fri, 11 Feb 2022 11:59:11 +0100 From: Jakub Jelinek To: Mohamed Atef Cc: Martin Jambor , gcc@gcc.gnu.org Subject: Re: adding OMPD support Message-ID: <20220211105911.GP2646553@tucnak> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2022 10:59:25 -0000 On Fri, Feb 11, 2022 at 12:46:32AM +0200, Mohamed Atef wrote: > i want to make the variable ompd_dll_locations global to openMP > runtime according to my understanding i should add it to OMP_5.1 {} in Given that it is not going to make GCC 12 which introduced the OMP_5.1 symbol version, our policy is that symbols shouldn't be added to symbol versions that were already released in earlier compiler versions. But, ompd_dll_locations has been introduced already in OpenMP 5.0, not 5.1, so it should go into: OMP_5.0.3 { global: ompd_dll_locations; } OMP_5.0.2; rather than OMP_5.1.1. > libgomp.map and its definition should be done in initialize_env() function > in env.c is there anything else needed to be done. Introduction of ompd_dll_locations is just one of the many steps to implement OMPD, and I'd say it should go together with actually introducing the libgompd library in libgomp/Makefile.am because the var just points to the library. Note, if you only make changes inside of libgomp/, you don't really need to rebuild the whole compiler for it, it is enough to run make in the /libgomp/ subdir of the builddir, and similarly for testing you could just run make check in that directory (at least during your development process, before submitting patches to gcc-patches full bootstrap/regtest should be done). > another question i modified the source and rebuilt gcc would i be able to > see my changes if i used the new gcc? If yes, why do we implement testsuite? Sure, you can see it through readelf -Wa on .libs/libgomp.so.1 or ideally tested in a testcase added into the libgomp testsuite. > By the way, we should finish the implementation by next july, so we need > your help. That help can come when you actually post patches and in patch review we can guide you what should be changed and how and what is ok. Jakub