From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id CEBD73858D38; Fri, 28 Oct 2022 19:20:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CEBD73858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 29SJJB0R001722; Fri, 28 Oct 2022 14:19:11 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 29SJJAhK001721; Fri, 28 Oct 2022 14:19:10 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 28 Oct 2022 14:19:10 -0500 From: Segher Boessenkool To: Jan-Benedict Glaw Cc: Aldy Hernandez , David Edelsohn , Kewen Lin , gcc@gcc.gnu.org Subject: Re: --target=powerpc64-linux_altivec: Use rs6000_linux64_override_options()? Message-ID: <20221028191910.GE25951@gate.crashing.org> References: <20221028173424.vxsqkj6wf2k3inoa@lug-owl.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221028173424.vxsqkj6wf2k3inoa@lug-owl.de> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On Fri, Oct 28, 2022 at 07:34:24PM +0200, Jan-Benedict Glaw wrote: > While checking my bot build logs, I noticed that GCC configured for > --target=powerpc64-linux_altivec will pull in linux64.h and > linuxaltivec.h . > > linux64.h > * Will "#define TARGET_USES_LINUX64_OPT 1" (to make static void > rs6000_linux64_override_options() available in rs6000.cc). > * Will "#define SUBSUBTARGET_OVERRIDE_OPTIONS" to use > rs6000_linux64_override_options(). > > linuxaltivec.h OTOH > * Will undef / "#define SUBSUBTARGET_OVERRIDE_OPTIONS rs6000_altivec_abi = 1" > and thus no longer use rs6000_linux64_override_options() > * That triggers a warning (unused-function). > > To silence that warning, should linuxaltivec.h undefine > TARGET_USES_LINUX64_OPT? Or set rs6000_altivec_abi=1 and call > rs6000_linux64_override_options()? Why do you use powerpc64-linux_altivec? This things (normally spelled with a dash, not and underscore, btw) was made for 32-bit targets. It never has done anything useful for 64-bit targets, afaik? (And not for 32-bit targets either really, but that is another issue.) Segher