From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jbglaw@lug-owl.de>
Received: from lug-owl.de (lug-owl.de [188.68.32.151])
	by sourceware.org (Postfix) with ESMTPS id 918D43858D37;
	Fri, 28 Oct 2022 20:07:43 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 918D43858D37
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lug-owl.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lug-owl.de
Received: by lug-owl.de (Postfix, from userid 1001)
	id BC63E4204B; Fri, 28 Oct 2022 22:07:41 +0200 (CEST)
Date: Fri, 28 Oct 2022 22:07:41 +0200
From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Aldy Hernandez <aldyh@redhat.com>, David Edelsohn <dje.gcc@gmail.com>,
	Kewen Lin <linkw@gcc.gnu.org>, gcc@gcc.gnu.org
Subject: Re: --target=powerpc64-linux_altivec: Use
 rs6000_linux64_override_options()?
Message-ID: <20221028200741.dau6ut2edeq5cusw@lug-owl.de>
References: <20221028173424.vxsqkj6wf2k3inoa@lug-owl.de>
 <20221028191910.GE25951@gate.crashing.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="k5dbcbo3x6nkmeuy"
Content-Disposition: inline
In-Reply-To: <20221028191910.GE25951@gate.crashing.org>
X-Operating-System: Linux chamaeleon 5.14.0-0.bpo.2-amd64 
X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444  A961 1DBD 5E75 8399 E1BB
X-gpg-key: wwwkeys.de.pgp.net
X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear
 warfare test the bombastical terror of flooding the spy listeners explosion
 sex drugs and rock'n'roll
X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare
 test the bombastical terror of flooding the spy listeners explosion sex
 drugs and rock'n'roll
X-message-flag: Please send plain text messages only. Do not send HTML
 emails. Thank you. 
User-Agent: NeoMutt/20170113 (1.7.2)
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc.gcc.gnu.org>


--k5dbcbo3x6nkmeuy
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

On Fri, 2022-10-28 14:19:10 -0500, Segher Boessenkool <segher@kernel.crashi=
ng.org> wrote:
> On Fri, Oct 28, 2022 at 07:34:24PM +0200, Jan-Benedict Glaw wrote:
> > While checking my bot build logs, I noticed that GCC configured for
> > --target=3Dpowerpc64-linux_altivec will pull in linux64.h and
> > linuxaltivec.h .
> >=20
> > linux64.h
> >   * Will "#define TARGET_USES_LINUX64_OPT 1" (to make static void
> >     rs6000_linux64_override_options() available in rs6000.cc).
> >   * Will "#define SUBSUBTARGET_OVERRIDE_OPTIONS" to use
> >     rs6000_linux64_override_options().
> >=20
> > linuxaltivec.h OTOH
> >   * Will undef / "#define SUBSUBTARGET_OVERRIDE_OPTIONS  rs6000_altivec=
_abi =3D 1"
> >     and thus no longer use rs6000_linux64_override_options()
> >   * That triggers a warning (unused-function).
> >=20
> > To silence that warning, should linuxaltivec.h undefine
> > TARGET_USES_LINUX64_OPT? Or set rs6000_altivec_abi=3D1 and call
> > rs6000_linux64_override_options()?
>=20
> Why do you use powerpc64-linux_altivec?  This things (normally spelled
> with a dash, not and underscore, btw) was made for 32-bit targets.  It
> never has done anything useful for 64-bit targets, afaik?

Because it's listed in ./contrib/config-list.mk:

/var/cache/git/gcc [master] # make -f contrib/config-list.mk show | tr ' ' =
$'\n' | grep altivec
powerpc-eabisimaltivec
powerpc-eabialtivec
powerpc64-linux_altivec

> (And not for 32-bit targets either really, but that is another issue.)

It seems to be on the target list since the very beginning, when
config-list.mk was created by Joern Rennecke. So somebody cared about
this configuration I guess?

  If this configuration isn't ment to be used, we'd just drop it from
the list I guess.

MfG, JBG

--=20

--k5dbcbo3x6nkmeuy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCY1w2jQAKCRAdvV51g5nh
u/VMAJ9QSf34x3ZnvxRmZgUxjGpCI2cJ9wCffVvcES2G39ogbdY5XeMrfCoC9NA=
=zlFT
-----END PGP SIGNATURE-----

--k5dbcbo3x6nkmeuy--