From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) by sourceware.org (Postfix) with ESMTPS id A1C2F3858D1E for ; Tue, 20 Jun 2023 16:51:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A1C2F3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=kitware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kitware.com Received: by mail-ua1-x92b.google.com with SMTP id a1e0cc1a2514c-78f3f8ecc42so1029420241.0 for ; Tue, 20 Jun 2023 09:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kitware.com; s=google; t=1687279876; x=1689871876; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MyfAYO9ArW9l4GKhJ/2qccsVxvV31RCH6w8mv24vgfM=; b=oMvKePbn+IO7YxViIf130OVBOxv2w7yAMAaDjQgwTzh4GbKUezueSt2iD61hqhvaOp smJA8fDB+R9rKJ47Byhf/oInC1DwwyUb+TOhdQGWmC+9gaMgEY0r10oMckzoOT0yF6JA PRVaUy9+AIQfA0TEftp2ts3PCmDS2viYNCVSc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687279876; x=1689871876; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MyfAYO9ArW9l4GKhJ/2qccsVxvV31RCH6w8mv24vgfM=; b=cc8HjU7K7nI7v6cVYZayjFFjVG4op2IL3Dy/D3wpiAEN6E9AYtvy4dUSHgf6Jechfz f+LAq4+2ziXktGO264f5p+UDyAuMPqrXpYxMsZ5FhraaxzxyEsv9tSXvwArUE1Gdo5j4 rTcE5pSkPhbbahP4BETbn0hxas7rIa0sxXrerHS84/BkonT7pchDR26Xl8hwYLnc3yKD eKrgHnZhQPvL6N0L5DdSOPg4lAI3mZDHNTPwFEZL108xrSChdnkFN25zgrT3+N699QnE 1WXKFQbhQMANGvAiqbyS56xfTKGoL4tWJmRapHgMl5+UKW583LSt77o88BiOFlnULW2K hC0A== X-Gm-Message-State: AC+VfDzOZcnVB8+vwgCuHj6or5PYjh9J+czpnWmQcZ9Z2c2Xe9SKvStn VznChWlTflipfVbRSzLh/QlivQ== X-Google-Smtp-Source: ACHHUZ7Ayj5IVM0Lwb15QL2TKqkEPhpvbobTMwZUhkYkUtjJBbEeXzDNLD+/ULBzGDgl3jF6a2iZCA== X-Received: by 2002:a67:e3aa:0:b0:440:b1b0:e5fa with SMTP id j10-20020a67e3aa000000b00440b1b0e5famr2311819vsm.21.1687279875877; Tue, 20 Jun 2023 09:51:15 -0700 (PDT) Received: from localhost ([66.194.253.28]) by smtp.gmail.com with ESMTPSA id f2-20020ad45582000000b0062febc332f0sm1389723qvx.130.2023.06.20.09.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 09:51:15 -0700 (PDT) Date: Tue, 20 Jun 2023 12:51:14 -0400 From: Ben Boeckel To: Jason Merrill Cc: gcc-patches@gcc.gnu.org, nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com Subject: Re: [PATCH v5 3/5] p1689r5: initial support Message-ID: <20230620165114.GA187468@farprobe> References: <20230125210636.2960049-1-ben.boeckel@kitware.com> <20230125210636.2960049-4-ben.boeckel@kitware.com> <77ee5db6-e45e-5178-4807-5b2fef29e8c7@redhat.com> <44880095-f972-ca16-f75b-2c64940e0433@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <44880095-f972-ca16-f75b-2c64940e0433@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jun 19, 2023 at 17:33:58 -0400, Jason Merrill wrote: > On 5/12/23 10:24, Ben Boeckel wrote: > > `file` can be omitted (the `output_stream` will be used then). I *think* > > I see that adding: > > > > %{fdeps_file:-fdeps-file=%{!o:%b.ddi}%{o*:%.ddi%*}} > > %{!fdeps-file: but yes. > > > would at least do for `-fdeps-file` defaults? I don't know if there's a > > reasonable default for `-fdeps-target=` though given that this command > > line has no information about the object file that will be used (`-o` is > > used for preprocessor output since we're leaning on `-E` here). > > I would think it could default to %b.o? I suppose that could work, yes. > I had quite a few more comments on the v5 patch that you didn't respond > to here or address in the v6 patch; did your mail client hide them from you? Oof. Sorry, I saw large chunks of quoting and apparently assumed the rest was fine (I usually do aggressive trimming when doing that style of review). I see them now. Will go through and include in v7. --Ben