From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by sourceware.org (Postfix) with ESMTPS id D8E813858D1E for ; Tue, 20 Jun 2023 19:49:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D8E813858D1E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=kitware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kitware.com Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-3fde00693cfso40930151cf.3 for ; Tue, 20 Jun 2023 12:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kitware.com; s=google; t=1687290588; x=1689882588; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=wQFhZqds8+agUGriyoeAHnGf0aGyIpV7YW3Auztc9Xk=; b=KElVBFSiBYKBAlxmWnuDLHMaKNUYmADPGe6fKGOjp42mZ4eFcJdwLg7+ymnGRMwYtX Gp5/Q7j4V1ln4lAOJWex/GI9kS0pRxQYJvvIEAsY3bagUddUyEwYH95ayi/50XiW4ZZ4 OaQOBZ5Ii+Bh7iNKw05rs+2d/steR57exg7Z0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687290588; x=1689882588; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wQFhZqds8+agUGriyoeAHnGf0aGyIpV7YW3Auztc9Xk=; b=gjn+cFgRR0RNQu23S6/SphlTTB6V/vBfzENRCDlcxheA1eWjc4+DCTZ0rO2GPyjYnL jvQYyFi70uzN8t024/VabS93Sb5AM8GePnRQWYmygjPNWSqlbS+qIatHMEWsgNdF5zQU H6W/XQmehSlY1M45E7SjN1IN5sZ5+BtYGCIFZmLNlb65WwzdnPY1i/bZrlDYNec1kXgG RgXSWsHMdDojZO8+uLHwIHs1vSZeSJ6Hv6ecA+5AnJvOld/Ohbz+1mSSENzR3NonwObK M9ZPkwYEEfGTMDxFwaeJr64eMJKHy+nuQrw//2VSuvutYd91J9mKfyrggmMQmQxNwmo1 t5ag== X-Gm-Message-State: AC+VfDztiStZdmd7rQKONY78zXHRawgSpuX8lI3fIwVk9UO7n5kH8MBA QCUa2+gLvaxLhMvL30vEdJuIIA== X-Google-Smtp-Source: ACHHUZ4lsTpvdPTpYQVbrvQxw48ltkbgndAjtvpsWlrS59qpsV2xdH7K1CT+bSTsQGhoA5iqd+Bv/A== X-Received: by 2002:a05:6214:19e6:b0:630:7d0:56f4 with SMTP id q6-20020a05621419e600b0063007d056f4mr13304236qvc.49.1687290588195; Tue, 20 Jun 2023 12:49:48 -0700 (PDT) Received: from localhost ([66.194.253.28]) by smtp.gmail.com with ESMTPSA id d5-20020ad450a5000000b0062ffcda34c6sm1553322qvq.137.2023.06.20.12.49.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 12:49:47 -0700 (PDT) Date: Tue, 20 Jun 2023 15:49:46 -0400 From: Ben Boeckel To: Damien Guibouret Cc: Jason Merrill , gcc@gcc.gnu.org Subject: Re: [PATCH v6 1/4] libcpp: reject codepoints above 0x10FFFF Message-ID: <20230620194946.GB186848@farprobe> References: <20230606205025.3164738-1-ben.boeckel@kitware.com> <20230606205025.3164738-2-ben.boeckel@kitware.com> <8e347f55-8102-a2a0-a98d-7d3155d1ea8a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jun 20, 2023 at 21:16:40 +0200, Damien Guibouret wrote: > I think the comparison should be ">" instead of ">=" as 0x10ffff seems a > valid value (Unicode says value above 0x10ffff is invalid). > Other tests around same value in this file are using ">". Ah, good catch. I'll make a separate patch submission for that. --Ben