From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 0E1FB3858C50 for ; Sun, 3 Mar 2024 21:15:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E1FB3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0E1FB3858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709500543; cv=none; b=M3oHRQsmqDIxJsZp8e7EvL7L5OHit7HMM05X2MuCdV4EOtj0scJCP5k1H71qEs+Vx7ZDCsAp9Z3gGfDlrSCw8FOksoPNmEi/dJQRGljFEp3PmsMUWT7vLhGbob19I2A0rcjePUwXS36+Z5KVGMuz0VzifhXLY/rjtmEHx+hHgHk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709500543; c=relaxed/simple; bh=zhgguG1HJoTZNUVcikjKmCOxAppGZDcCdCR0rePfVzo=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=iDnAdhcEruj3ZHHqHWMZFyq0MDaS520T5AWoGb+XPt2SKwzSQu3MxAohJe1AjEEGbI0FvM2Z+JgrxdaNYQSYPywk6ywqWtz+VVpMTXuYDwNINnpZ6ARpCAAemTepM9oZRvHW3BY8WMa1eftFJewERjcVCOMkNVK8psw9Ivn6npY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 1F4C03000648; Sun, 3 Mar 2024 22:15:41 +0100 (CET) Date: Sun, 3 Mar 2024 22:15:41 +0100 From: Mark Wielaard To: Christophe Lyon Cc: binutils@sourceware.org, GCC Mailing List , gdb-patches@sourceware.org, David Malcolm , arsen@gentoo.org, sam@gentoo.org Subject: Re: Help needed with maintainer-mode Message-ID: <20240303211541.GK13156@gnu.wildebeest.org> References: <20240229110039.GB18580@gnu.wildebeest.org> <72dff8ae4cc6b56208b7e7f93676debcaba900d4.camel@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Christophe, On Fri, Mar 01, 2024 at 05:32:15PM +0100, Christophe Lyon wrote: > > > > And it was indeed done this way because that way the files are > > > > regenerated in a reproducible way. Which wasn't the case when using --enable-maintainer-mode (and autoreconfig also doesn't work). > > > > > > I see. So it is possibly incomplete, in the sense that it may lack > > > some of the steps that maintainer-mode would perform? > > > For instance, gas for aarch64 has some *opcodes*.c files that need > > > regenerating before committing. The regeneration step is enabled in > > > maintainer-mode, so I guess the autoregen bots on Sourceware would > > > miss a problem with these files? > > > > Yes, it is certainly incomplete. But it is done this way because it is > > my understanding that even the gcc release maintainers do the > > automake/autoconf invocations by hand instead of running with configure > > --enable-maintainer-mode. > > After a discussion on IRC, I read > https://gcc.gnu.org/wiki/Regenerating_GCC_Configuration > which basically says "run autoreconf in every dir where there is a > configure script" > but this is not exactly what autoregen.py is doing. IIRC it is based > on a script from Martin Liska, do you know/remember why it follows a > different process? CCing Sam and Arsen who helped refine the autoregen.py script, who might remember more details. We wanted a script that worked for both gcc and binutils-gdb. And as far as I know autoreconf simply didn't work in all directories. We also needed to skip some directories that did contain a configure script, but that were imported (gotools, readline, minizip). Cheers, Mark