From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id CC1B93858C56 for ; Thu, 4 Apr 2024 21:35:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC1B93858C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC1B93858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712266504; cv=none; b=UdN5WITImeIKNAmeDomXLLJLPxg0EuxjxDWHmpOZg4/rwshTR5iXtBNuiqbzF1q89B4GlH+GbN7K1k53Ab1doIPbDKBkEnwtZTgLIPxVfR985EJ7B8E2k9bDv22rVN5X/LJ4xJ4JRw1XMLJ3Yc9sLb7lMFEi4j8UHHo2Tvc2Yn0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712266504; c=relaxed/simple; bh=iS54bwDPCl6Q6eKfAUo61lQOJbiytkSQw2hdU9KPyVo=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=vmco5E0P3Xd6XX98iZYbYh6u5WGBL0c05Cx8QBr0+ri+fCbAdzSx3UGgr4s81fCbxGggVJfWHMUnr2oD250MEkXa7UacoUs2/L/dMLyh8zHkF4rEyQHQi1RDwtqlWsKmfWSsha7pMywr3aTgPjrelUDHT4xnN41APEEb6LTDfz0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id CF60E3000593; Thu, 4 Apr 2024 23:35:01 +0200 (CEST) Date: Thu, 4 Apr 2024 23:35:01 +0200 From: Mark Wielaard To: Christophe Lyon Cc: binutils@sourceware.org, GCC Mailing List , gdb@sourceware.org, Nick Clifton , Richard Biener , Jakub Jelinek , Joel Brobecker , Carlos O'Donell , Maxim Kuvyrkov , Thiago Bauermann , Adhemerval Zanella Subject: Re: Patches submission policy change Message-ID: <20240404213501.GL19937@gnu.wildebeest.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Christophe, On Wed, Apr 03, 2024 at 10:22:24AM +0200, Christophe Lyon via Gdb wrote: > TL;DR: For the sake of improving precommit CI coverage and simplifying > workflows, I’d like to request a patch submission policy change, so > that we now include regenerated files. This was discussed during the > last GNU toolchain office hours meeting [1] (2024-03-28). > > Benefits or this change include: > - Increased compatibility with precommit CI > - No need to manually edit patches before submitting, thus the “git > send-email” workflow is simplified > - Patch reviewers can be confident that the committed patch will be > exactly what they approved > - Precommit CI can test exactly what has been submitted > > Any concerns/objections? I am all for it. It will make testing patches easier for everyone. I do think we still need a better way to make sure all generated files can be regenerated. If only to check that the files were generated correctly with the correct versions. The autoregen buildbots are able to catch some, but not all such mistakes. wrt to the mailinglists maybe getting larger patches, I think most will still be under 400K and I wouldn't raise the limit (because most such larger emails are really just spam). But we might want to get more mailinglist moderators. gcc-patches, binutils and gdb-patches all have only one moderator (Jeff, Ian and Thiago). It would probably be good if there were more. Any volunteers? It shouldn't be more than 1 to 3 emails a week (sadly most of them spam). Cheers, Mark