From: "Frank Ch. Eigler" <fche@redhat.com>
To: brobecker@adacore.com
Cc: gdb@sourceware.org, gcc@gcc.gnu.org
Subject: adacore git-hooks - daemon-mode email vs. systemd-logind linger
Date: Tue, 16 Apr 2024 06:56:22 -0400 [thread overview]
Message-ID: <20240416105622.GD1423@redhat.com> (raw)
Hi, Joel -
As a part of more security review on sourceware, I had recently
experimented with systemd logind's KillUserProcesses=yes option. It
turns out that this nuked one aspect adacore hooks' post-receive
processing, which create a background process to slowly dribble out
emails.
I restored KilledUserProcesses=no for now, but I'd really like to set
that back. That means the hooks would have to change. Here are a
couple of options:
- just send the emails immediately, without the daemon stuff; if the
delays are there to try to sequentialize them, consider instead
getting the hooks to emit Message-Id:/In-Reply-To:/Date: headers to
let MUA's sort properly at reception
- invoke the email sending wrapped in a "systemd-run --user"
deferred execution gadget, including a "sleep XXX" if you must
keep time-hope-based sequencing
- move email stuff entirely out of the hooks; these repos are "public
property" anyhow, and we can put cron jobs in place elsewhere to
trigger email notifications about commits; heck, they could run the
hook code itself later, just feed it retrospective git-hook lines
- FChE
next reply other threads:[~2024-04-16 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 10:56 Frank Ch. Eigler [this message]
2024-04-19 19:11 ` Joel Brobecker
2024-04-19 19:28 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416105622.GD1423@redhat.com \
--to=fche@redhat.com \
--cc=brobecker@adacore.com \
--cc=gcc@gcc.gnu.org \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).