From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rask Ingemann Lambertsen" To: "David Edelsohn" Cc: egcs@cygnus.com Subject: Re: gcc/config/rs6000/rs6000.h bug? Date: Sat, 18 Jul 1998 11:59:00 -0000 Message-id: <2069.503T815T10953323@kampsax.k-net.dk> References: <9807181332.AA29930@rios1.watson.ibm.com> X-SW-Source: 1998-07/msg00653.html Den 18-Jul-98 15:32:18 skrev David Edelsohn følgende om "Re: gcc/config/rs6000/rs6000.h bug? ": > Rask> thus making the assumption that all the PowerPC targets that use the > System Rask> V.4 ABI run the SVR4 OS. Is it really supposed to be like that? > This only means that the PowerPC System V.4 configuration uses the > common GCC System %.4 configuration as a base -- not that it runs SVR4 > OS. It simply avoids defining and maintaining duplicative configuration > details. Yes, sorry, I mixed up "gcc/config/rs6000/rs6000.h" with "gcc/config/rs6000/xm-rs6000.h" and "gcc/config/svr4.h" with "gcc/config/xm-svr4.h". And anyway, the offending #include "xm-svr4.h" isn't there any longer in the CVS repository, so cheers for that. This doesn't mean that I can't find something else to complain about, though. ;-) A freshly checked out "gcc/config/rs6000/xm-rs6000.h" contains: --------- /* Arguments to use with `exit'. */ #define SUCCESS_EXIT_CODE 0 #define FATAL_EXIT_CODE 33 --------- which should be removed since already define them (and even to correct values). At least they should be protected by #ifndef, but they are not Power(PC) specific and thus don't belong here. But wait, there's more: ---------- /* AIX is a flavor of System V */ #define USG ---------- and ---------- #ifndef CROSS_COMPILE /* The AIX linker will discard static constructors in object files before collect has a chance to see them, so scan the object files directly. */ #define COLLECT_EXPORT_LIST #endif ---------- which IMHO belongs in xm-aix??.h, not in xm-rs6000.h. Regards, /¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯T¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯\ | Rask Ingemann Lambertsen | E-mail: mailto:rask@kampsax.k-net.dk | | Registered Phase5 developer | WWW: http://www.gbar.dtu.dk/~c948374/ | | A4000, 775 kkeys/s (RC5-64) | "ThrustMe" on XPilot, ARCnet and IRC | | Keyboard error: and are stuck - press to continue |