public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* suggestion for egcs-1.1 branch, MKTEMP_EACH_FILE
@ 1999-02-15 14:09 Marc Espie
       [not found] ` < 19990215230912.55377@liafa1.liafa.jussieu.fr >
  1999-02-28 22:53 ` Marc Espie
  0 siblings, 2 replies; 4+ messages in thread
From: Marc Espie @ 1999-02-15 14:09 UTC (permalink / raw)
  To: egcs

It would be a good idea  to include the changes relevant to 
MKTEMP_EACH_FILE in the  upcoming egcs-1.1 bug-fixed.

This is an important security fix, as the use of mkstemps removes a bad
race condition on /tmp/ files... it's also easy to pick up & include, 
I even added it to gcc 2.8.1 on OpenBSD.

(check MKTEMP_EACH_FILE in gcc.c, include the modified
libiberty/choose-temp.c,
libiberty/mkstemps.c, and the relevant recent changes to
libiberty/configure.in and various Makefile fragments, namely use 
libiberty.a where appropriate).

I don't have easy net access tonight, but if it's needed, I can provide
the corresponding patch.
-- 
	Marc Espie		
|anime, sf, juggling, unicycle, acrobatics, comics...
|AmigaOS, OpenBSD, C++, perl, Icon, PostScript...
| `real programmers don't die, they just get out of beta'

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: suggestion for egcs-1.1 branch, MKTEMP_EACH_FILE
       [not found] ` < 19990215230912.55377@liafa1.liafa.jussieu.fr >
@ 1999-02-16  0:47   ` Jeffrey A Law
  1999-02-28 22:53     ` Jeffrey A Law
  0 siblings, 1 reply; 4+ messages in thread
From: Jeffrey A Law @ 1999-02-16  0:47 UTC (permalink / raw)
  To: Marc Espie; +Cc: egcs

  In message < 19990215230912.55377@liafa1.liafa.jussieu.fr >you write:
  > It would be a good idea  to include the changes relevant to 
  > MKTEMP_EACH_FILE in the  upcoming egcs-1.1 bug-fixed.
  > 
  > This is an important security fix, as the use of mkstemps removes a bad
  > race condition on /tmp/ files... it's also easy to pick up & include, 
  > I even added it to gcc 2.8.1 on OpenBSD.
  > 
  > (check MKTEMP_EACH_FILE in gcc.c, include the modified
  > libiberty/choose-temp.c,
  > libiberty/mkstemps.c, and the relevant recent changes to
  > libiberty/configure.in and various Makefile fragments, namely use 
  > libiberty.a where appropriate).
  > 
  > I don't have easy net access tonight, but if it's needed, I can provide
  > the corresponding patch.
Ummm, egcs-1.1 already has the MKTEMP_EACH_FILE changes.  The only thing I
think it's missing is the recent bugfix.

I'm not planning on adding all the other stuff (rename the file, make mkstemps
conditionally included, etc).

jeff

^ permalink raw reply	[flat|nested] 4+ messages in thread

* suggestion for egcs-1.1 branch, MKTEMP_EACH_FILE
  1999-02-15 14:09 suggestion for egcs-1.1 branch, MKTEMP_EACH_FILE Marc Espie
       [not found] ` < 19990215230912.55377@liafa1.liafa.jussieu.fr >
@ 1999-02-28 22:53 ` Marc Espie
  1 sibling, 0 replies; 4+ messages in thread
From: Marc Espie @ 1999-02-28 22:53 UTC (permalink / raw)
  To: egcs

It would be a good idea  to include the changes relevant to 
MKTEMP_EACH_FILE in the  upcoming egcs-1.1 bug-fixed.

This is an important security fix, as the use of mkstemps removes a bad
race condition on /tmp/ files... it's also easy to pick up & include, 
I even added it to gcc 2.8.1 on OpenBSD.

(check MKTEMP_EACH_FILE in gcc.c, include the modified
libiberty/choose-temp.c,
libiberty/mkstemps.c, and the relevant recent changes to
libiberty/configure.in and various Makefile fragments, namely use 
libiberty.a where appropriate).

I don't have easy net access tonight, but if it's needed, I can provide
the corresponding patch.
-- 
	Marc Espie		
|anime, sf, juggling, unicycle, acrobatics, comics...
|AmigaOS, OpenBSD, C++, perl, Icon, PostScript...
| `real programmers don't die, they just get out of beta'

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: suggestion for egcs-1.1 branch, MKTEMP_EACH_FILE
  1999-02-16  0:47   ` Jeffrey A Law
@ 1999-02-28 22:53     ` Jeffrey A Law
  0 siblings, 0 replies; 4+ messages in thread
From: Jeffrey A Law @ 1999-02-28 22:53 UTC (permalink / raw)
  To: Marc Espie; +Cc: egcs

  In message < 19990215230912.55377@liafa1.liafa.jussieu.fr >you write:
  > It would be a good idea  to include the changes relevant to 
  > MKTEMP_EACH_FILE in the  upcoming egcs-1.1 bug-fixed.
  > 
  > This is an important security fix, as the use of mkstemps removes a bad
  > race condition on /tmp/ files... it's also easy to pick up & include, 
  > I even added it to gcc 2.8.1 on OpenBSD.
  > 
  > (check MKTEMP_EACH_FILE in gcc.c, include the modified
  > libiberty/choose-temp.c,
  > libiberty/mkstemps.c, and the relevant recent changes to
  > libiberty/configure.in and various Makefile fragments, namely use 
  > libiberty.a where appropriate).
  > 
  > I don't have easy net access tonight, but if it's needed, I can provide
  > the corresponding patch.
Ummm, egcs-1.1 already has the MKTEMP_EACH_FILE changes.  The only thing I
think it's missing is the recent bugfix.

I'm not planning on adding all the other stuff (rename the file, make mkstemps
conditionally included, etc).

jeff

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~1999-02-28 22:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-02-15 14:09 suggestion for egcs-1.1 branch, MKTEMP_EACH_FILE Marc Espie
     [not found] ` < 19990215230912.55377@liafa1.liafa.jussieu.fr >
1999-02-16  0:47   ` Jeffrey A Law
1999-02-28 22:53     ` Jeffrey A Law
1999-02-28 22:53 ` Marc Espie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).