From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 85ACC395445A for ; Thu, 17 Jun 2021 14:55:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 85ACC395445A Received: by mail-ot1-x332.google.com with SMTP id w23-20020a9d5a970000b02903d0ef989477so6371334oth.9 for ; Thu, 17 Jun 2021 07:55:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s6N8VODVqlwNZFNB7KIxToGysoMv3cbfrO51gwotKBM=; b=JT1tvwQeHGSczK5BAtOC9pMao2ER4UEc0a/V+7QC6tdPO3PtKxpMJ9StWTYHMRF40F IWjqydpQnVi2RGh3wie30MTwxqyJI3Xe3S+oNMk2O+HVWdKzqc9yBEifjAKB6SL7corx 7nTUeM+QXEmAX6DMOlieFiNmmGYCI+WA8kQsR8jjA5M42P0yyF+ooYTCyVMl665WDbZi SxEL7hTpJJd6c9QXsCU4wW2VDxcDCA6sQYJJmXkkjur9a5m/xfOkW7U5mmgiwinNLEFe qhIA7bVjk3ojOyKHO+424DagQo71bz/2LFHf2wP/yh1sm34PRNwhwHY7ylWLlY5ssAEA CXEQ== X-Gm-Message-State: AOAM532oSRe1hFeSPxOX2RxIaq+V1kr1yOx/HwQLz7mCNIPlPkBsYsnn 7PMbX8f/D9coydLz3dGKexwFlC+rprI= X-Google-Smtp-Source: ABdhPJzZNypgyUKDZD+8A75/8Mz84LJNMeUx9yAUWHUEAUUt3Iq61cmS2DMWIubCwl6JOuErhI//sw== X-Received: by 2002:a9d:2aa9:: with SMTP id e38mr4971956otb.78.1623941701750; Thu, 17 Jun 2021 07:55:01 -0700 (PDT) Received: from [192.168.0.41] (97-118-105-195.hlrn.qwest.net. [97.118.105.195]) by smtp.gmail.com with ESMTPSA id c188sm1241149ooc.29.2021.06.17.07.55.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 07:55:01 -0700 (PDT) Subject: Re: git gcc-commit-mklog doesn't extract PR number to ChangeLog To: Jonathan Wakely Cc: Jason Merrill , Hans-Peter Nilsson , Jakub Jelinek , gcc Mailing List References: <20210610173005.GI7746@tucnak> <20210610190941.GJ7746@tucnak> <58b63929-01f5-038c-931c-9ff8349d9f95@gmail.com> <71b4a023-efb2-6c6a-9ced-93cce7c96540@gmail.com> <013d6727-4008-b4b5-b793-c782a5ba8e10@redhat.com> <5b2bace3-2f6f-ce1c-98ef-726c65686656@gmail.com> From: Martin Sebor Message-ID: <21a8c8ab-3974-5e61-ef38-c5c55c23d75d@gmail.com> Date: Thu, 17 Jun 2021 08:55:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 14:55:03 -0000 On 6/17/21 4:18 AM, Jonathan Wakely wrote: > On Thu, 17 Jun 2021 at 02:01, Martin Sebor wrote: >> >> On 6/16/21 6:40 PM, Jason Merrill wrote: >>> On 6/16/21 8:17 PM, Martin Sebor wrote: >>>> 3) adds the PR component/nnnnn to each ChangeLog >>> >>> This would be reverting the r12-771 change, which seems both unrelated >>> and undesirable. >> >> Now I'm confused. Isn't that just what caused the problem to begin >> with? (The bug not being updated with the commit because it's not >> in the ChangeLog entries?) > > > No. > > The original problem is that the PR wasn't in the body of the commit AT ALL. But I see [PR100085] right there at the end of the summary line: https://gcc.gnu.org/pipermail/gcc/2021-June/236346.html and here: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=f700e4b0ee3ef53b48975cf89be26b9177e3a3f3 > > The current mklog.py will do this: > > PR cmpt/nnnn > > gcc/ChangeLog: > > * blah.c (blah): Blah blah. > > That will cause updates to bugzilla, it works fine. You do not need to > change it to: > > gcc/ChangeLog: > > PR cmpt/nnnn > * blah.c (blah): Blah blah. > > That would also work, but isn't necessary (and would be reverting the > r12-771 change). > > Either of the forms above will update bugzilla. The original problem > was that neither of those forms was used. You mean the sole reason why Bugzilla wasn't updated was that the component was missing from the PR? And the proposed change is to reject commits without the component bit? Why? Martin