From: Jeffrey A Law <law@cygnus.com>
To: Jim Wilson <wilson@cygnus.com>
Cc: hjl@lucon.org (H.J. Lu),
scox@cygnus.com, crux@pool.informatik.rwth-aachen.de,
egcs@cygnus.com
Subject: Re: More fp bug in egcs
Date: Tue, 05 May 1998 05:46:00 -0000 [thread overview]
Message-ID: <23019.894353515@hurl.cygnus.com> (raw)
In-Reply-To: <199805032254.PAA08319@rtl.cygnus.com>
In message < 199805032254.PAA08319@rtl.cygnus.com >you write:
> How does this patch look? It works for my test case.
>
> A reload patch is not a safe way to fix this problem. Your reload patch
> affects all programs for all targets. My patch affects only x86 programs
> that currently fail. Since my patch has much more limited scope, it is a
> much better solution for a egcs-1.0.3 bug fix release.
Agreed!
> I think it is a reload bug. I don't know what the purpose to output the
> last reload for a dead register. I don't what the best solution is and
> I am not sure if my patch covers all cases.
>
> I think it is more accurate to call it a `missed optimization' than a `bug',
> as the output is correct. The only reason it fails on the x86 is because of
> a i386.md bug which my patch fixes.
Agreed again.
HJ -- you're making the same fundamental mistake as you did with the
"disable regmove" bug which really turned out to be a bug in i386.md.
Jim's patch is more correct to fix the bug and several orders of
magnitude safer.
And I think both Jim and I agree that you can make a case for your
patch as an optimization -- in which case it would belong in the
development branch, not the release branch.
jeff
next prev parent reply other threads:[~1998-05-05 5:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-05-03 0:55 H.J. Lu
1998-05-03 12:03 ` H.J. Lu
1998-05-03 17:14 ` Jim Wilson
1998-05-04 11:17 ` H.J. Lu
1998-05-04 18:07 ` Jeffrey A Law
1998-05-04 18:07 ` H.J. Lu
1998-05-04 22:00 ` Jeffrey A Law
1998-05-08 16:04 ` Jeffrey A Law
1998-05-03 20:10 ` Jim Wilson
1998-05-05 5:46 ` Jeffrey A Law [this message]
-- strict thread matches above, loose matches on Subject: below --
1998-04-25 18:25 H.J. Lu
1998-04-27 21:29 ` Jim Wilson
1998-04-30 20:03 ` Jim Wilson
1998-05-02 18:56 ` H.J. Lu
1998-05-03 20:10 ` Jim Wilson
1998-05-05 0:35 ` Jeffrey A Law
1998-05-05 19:14 ` H.J. Lu
1998-05-06 11:49 ` Jim Wilson
1998-05-05 5:03 ` Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23019.894353515@hurl.cygnus.com \
--to=law@cygnus.com \
--cc=crux@pool.informatik.rwth-aachen.de \
--cc=egcs@cygnus.com \
--cc=hjl@lucon.org \
--cc=scox@cygnus.com \
--cc=wilson@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).