From: Jeffrey A Law <law@cygnus.com>
To: Marc Lehmann <pcg@goof.com>
Cc: egcs@cygnus.com
Subject: Re: Patch to -Os
Date: Sun, 01 Feb 1998 01:05:00 -0000 [thread overview]
Message-ID: <23649.886322510@hurl.cygnus.com> (raw)
In-Reply-To: <19980131210207.45108@cerebro.laendle>
In message <19980131210207.45108@cerebro.laendle>you write:
> anyway, here's a small patch that might make more sense than to disable
> -finline-functions altogether with -Os.
>
> The idea is that a function call is at least 1 instruction (call) plus 1.5
> instructions per argument (well, constants are one or two insns, simple
> variables are one or two insns..), so doing the inline with small functions
> might be even better than calling them, since the actual call needs more
> instructions (there _are_ such functions!)
>
> The patch re-enables -finline-functions with -Os and sets
> INTEGRATE_THRESHOLD to a small value when -Os is specified.
>
> Another (maybe much better!) approach would be to do this for
> all architectures, i.e. leaving flagh_inline_functions alone
> and just making the default for INTEGRATE_THRESHOLD smaller
> (although architectures that aslready define INTEGRATE_THRESHOLD
> need a change, then).
>
> any comments?
Well, I'd personally prefer to see flag_inline_funtions set for
-On for n > 2 (or maybe 3 since it can have much more of a size
impact than loop unrolling) in the machine independent code rather
than doing it in each backend.
Similarly for INTEGRATE_THRESHOLD, the change belongs in the target
independent code.
Can you rework your patch in that manner?
jeff
next prev parent reply other threads:[~1998-02-01 1:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-01-31 12:09 Marc Lehmann
1998-01-31 18:04 ` Joe Buck
1998-01-31 22:46 ` Stephen Williams
1998-02-01 0:37 ` Jeffrey A Law
1998-02-01 1:05 ` Jeffrey A Law [this message]
1998-02-02 17:14 Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23649.886322510@hurl.cygnus.com \
--to=law@cygnus.com \
--cc=egcs@cygnus.com \
--cc=pcg@goof.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).