From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id B8F083858D29 for ; Mon, 17 Jun 2024 12:42:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B8F083858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B8F083858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718628128; cv=none; b=N52FW9m8T32il/1WFtD+12VYHeR3fK65sxI7Qrr1V7uxtf53patWeM7CrShyKTjdBI4QeVAmD3LEp3YF0F7w2yDOERtjhH4eC23mFbr/whPzT5KjN6Gy0tUelmMofOtoxCojEIc3eYPZhCmrl9aOHrcBAVbJcBtjyxxJMh2aKaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718628128; c=relaxed/simple; bh=68GmhwN5ExQCgK+5RTXYKagFCIKzh7QWfhpeoI7BRdQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=QyOn2GuzAPYPlxPznf1b0QpQBpofk4myOELQYxvwXou1k6B+rqeCSJq/LffR2lg2g8/FPno5/bTHNhYEIfKS607ZanBzRIOaFCh6WZR6MPJo4bHB2EfhcXZLsb1YZzXZhpVj5Bcwv7m5J4SBTW2Bt1bKQ9UrkYn5fOXsu7Cg68k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D18216008C; Mon, 17 Jun 2024 12:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718628125; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4e8b1pwLWbBV4TwS1tsxpAGAjbDJD2eYuE7jo5c3emU=; b=FvZqRWoGeGogBRXonreiXXVVeIJZJ+r2G37ntU9dmAMW+hNBoIY0vY8TrNMNarW6wuLg9f 5Xoj/s0/qyImY+F29G8D+2aUT6lO6XY/rKjSJ31Bok7gDwg7QkqD6zprj55nsABiKuFMfS bB+vOGtPFRUtpVHldMZ2LJN1LqcGgJw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718628125; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4e8b1pwLWbBV4TwS1tsxpAGAjbDJD2eYuE7jo5c3emU=; b=vZr33/pD24/FXiA9sasswJs6K/ikTjbWWblSM6PYdjuZaMFc3CCIgDB64DWg2R93hXgRV2 RW66wPXZxlvNldBw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718628125; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4e8b1pwLWbBV4TwS1tsxpAGAjbDJD2eYuE7jo5c3emU=; b=FvZqRWoGeGogBRXonreiXXVVeIJZJ+r2G37ntU9dmAMW+hNBoIY0vY8TrNMNarW6wuLg9f 5Xoj/s0/qyImY+F29G8D+2aUT6lO6XY/rKjSJ31Bok7gDwg7QkqD6zprj55nsABiKuFMfS bB+vOGtPFRUtpVHldMZ2LJN1LqcGgJw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718628125; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4e8b1pwLWbBV4TwS1tsxpAGAjbDJD2eYuE7jo5c3emU=; b=vZr33/pD24/FXiA9sasswJs6K/ikTjbWWblSM6PYdjuZaMFc3CCIgDB64DWg2R93hXgRV2 RW66wPXZxlvNldBw== Date: Mon, 17 Jun 2024 14:42:05 +0200 (CEST) From: Richard Biener To: Martin Uecker cc: gcc@gcc.gnu.org, Joseph Myers , Jakub Jelinek Subject: Re: check_qualified_type In-Reply-To: <4aca9f8d18b29e4a6fd925477ca1d9a451992c8a.camel@tugraz.at> Message-ID: <24n46r00-qp22-r358-0qq6-q8s11rr89rp9@fhfr.qr> References: <147dbd85269a23623a7a33a862c1cfa4232aae84.camel@tugraz.at> <4aca9f8d18b29e4a6fd925477ca1d9a451992c8a.camel@tugraz.at> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1475677436-1443497133-1718628125=:4147" X-Spam-Score: -3.29 X-Spam-Level: X-Spamd-Result: default: False [-3.29 / 50.00]; BAYES_HAM(-3.00)[100.00%]; CTYPE_MIXED_BOGUS(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.19)[-0.968]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_ZERO(0.00)[0]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[] X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1475677436-1443497133-1718628125=:4147 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Mon, 17 Jun 2024, Martin Uecker wrote: > Am Montag, dem 17.06.2024 um 08:01 +0200 schrieb Richard Biener via Gcc: > > On Sun, 16 Jun 2024, Martin Uecker wrote: > > > > > > > > > > > I am trying to understand what check_qualified_type > > > does exactly. The direct comparison of TYPE_NAMES seems incorrect > > > for C and its use is c_update_type_canonical then causes > > > PR114930 and PR115502. In the later function I think > > > it is not really needed and I guess one could simply remove > > > it, but I wonder if it works incorrectly in other cases  > > > too? > > > > TYPE_NAMES is compared because IIRC typedefs are recorded as variants > > and 'const T' isn't the same as 'const int' with typedef int T. > > so if it is intentional that it differentiates between > > struct foo > > and > > typedef struct foo bar > > then I will change c_update_type_canonical to not use it, > because both types should have the same TYPE_CANONICAL The check is supposed to differentiate between variants and all variants have the same TYPE_CANONICAL so I'm not sure why you considered using this function for canonical type compute? Richard. ---1475677436-1443497133-1718628125=:4147--