From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeffrey A Law To: Richard Henderson Cc: "Kaveh R. Ghazi" , egcs@cygnus.com Subject: Re: egcs-980129, fixed ambiguous `else' warnings in the gcc/f/ dir. Date: Fri, 13 Feb 1998 02:28:00 -0000 Message-id: <25061.887354581@hurl.cygnus.com> References: <19980212011618.42585@dot.cygnus.com> X-SW-Source: 1998-02/msg00603.html In message < 19980212011618.42585@dot.cygnus.com >you write: > On Wed, Feb 11, 1998 at 04:57:39PM -0500, Kaveh R. Ghazi wrote: > > +++ egcs-980129/gcc/f/expr.c Tue Feb 3 15:50:59 1998 > > @@ -8761,10 +8761,12 @@ > > else > > { /* The normal stuff. */ > > if (nbt == lbt) > > - if (nbt == rbt) > > - nkt = ffeinfo_kindtype_max (nbt, lkt, rkt); > > - else > > - nkt = lkt; > > + { > > + if (nbt == rbt) > > + nkt = ffeinfo_kindtype_max (nbt, lkt, rkt); > > + else > > + nkt = lkt; > > + } > > else if (nbt == rbt) > > nkt = rkt; > > else > > It would be my preference that the pieces of the patch like this, > in which the if-then-else tree is full, _not_ be installed. This > will remind us that we should fix the bug in the warning code. Ah, I see where it's giving a false positive. I may have missed the trailing else when looking at the patches. Regardless I think the patch should have gone in. I'm working on a testcase for the testsuite right now. jeff