From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeffrey A Law To: Toon Moene Cc: Jim Wilson , egcs@cygnus.com Subject: Re: my EGCS status (really Fortran patches) Date: Sun, 26 Oct 1997 09:18:00 -0000 Message-id: <25086.877886431@hurl.cygnus.com> References: <9710211752.AA19479@moene.indiv.nluug.nl> X-SW-Source: 1997-10/msg01094.html In message <9710211752.AA19479@moene.indiv.nluug.nl>you write: > > The only obvious problem I can see in them is that the > > fold patch does not preserve SAVE_EXPRs. There should > > be a little bit of code that does > > if (have_save_expr) > > t = save_expr (t); > > We should not install this patch as is. Otherwise, it > > does seem that it should always give better code. > > Oops, does this show that I don't really understand this SAVE_EXPR > business :-( Interesting that I did a full build of my Fortran > software and a complete 24 hour run without any trouble ;-) Hmmm, Jim -- are you referring to the multiple_of_p patch that went in long ago? Or something else that I can't seem to find :-) If it's the multiple_of_p patch, then I think we're OK -- we never actually do anything with the SAVE_EXPR other than peek inside at the contents -- we don't pass it off fold or return any of the inner trees to the caller. jeff