public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeffrey A Law <law@cygnus.com>
To: hjl@lucon.org (H.J. Lu)
Cc: egcs@cygnus.com, drepper@gnu.ai.mit.edu (Ulrich Drepper)
Subject: Re: Another libio patch
Date: Mon, 17 Nov 1997 13:57:00 -0000	[thread overview]
Message-ID: <25686.879803953@hurl.cygnus.com> (raw)
In-Reply-To: <m0xXY3s-0004ecC@ocean.lucon.org>

  In message < m0xXY3s-0004ecC@ocean.lucon.org >you write:
  > Here is another libio patch.
  > 
  > -- 
  > H.J. Lu (hjl@gnu.ai.mit.edu)
  > ---
  > Mon Nov 17 08:39:17 1997  H.J. Lu  (hjl@gnu.ai.mit.edu)
  > 
  > 	* stdstrbufs.cc (DEF_STDFILE): Use STD_VTABLE.
I have no idea what this patch does since you didn't make any attempt to
describe the problem it's trying to fix.  I will not install it unless I
hear from Ulrich.

Ulrich -- is this patch correct?

  > 
  > Index: stdstrbufs.cc
  > ===================================================================
  > RCS file: /home/work/cvs/gnu/egcs/libio/stdstrbufs.cc,v
  > retrieving revision 1.1.1.2
  > diff -u -r1.1.1.2 stdstrbufs.cc
  > --- stdstrbufs.cc	1997/09/17 20:12:34	1.1.1.2
  > +++ stdstrbufs.cc	1997/11/17 20:38:04
  > @@ -58,7 +58,7 @@
  >  #define DEF_STDFILE(NAME, FD, CHAIN, FLAGS) \
  >    static _IO_lock_t _IO_stdfile_##FD##_lock = _IO_lock_initializer; \
  >    struct _IO_FILE_plus NAME \
  > -    = {FILEBUF_LITERAL(CHAIN, FLAGS, FD), &_IO_file_jumps}
  > +    = {FILEBUF_LITERAL(CHAIN, FLAGS, FD), STD_VTABLE}
  >  #else
  >  #define DEF_STDFILE(NAME, FD, CHAIN, FLAGS) \
  >    struct _IO_FILE_plus NAME = {FILEBUF_LITERAL(CHAIN, FLAGS, FD), STD_VTAB
  > LE}

  reply	other threads:[~1997-11-17 13:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1997-11-17 13:18 H.J. Lu
1997-11-17 13:57 ` Jeffrey A Law [this message]
1997-11-17 15:03   ` H.J. Lu
  -- strict thread matches above, loose matches on Subject: below --
1997-10-10 15:09 H.J. Lu
1997-10-10 22:58 ` Ulrich Drepper
1997-10-11  9:49   ` H.J. Lu
1997-10-13  5:49 ` Neal Becker
1997-10-17 13:49   ` H.J. Lu
1997-08-27 16:44 H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25686.879803953@hurl.cygnus.com \
    --to=law@cygnus.com \
    --cc=drepper@gnu.ai.mit.edu \
    --cc=egcs@cygnus.com \
    --cc=hjl@lucon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).