From: "Björn Schäpers" <gcc@hazardy.de>
To: Ian Lance Taylor <iant@golang.org>
Cc: gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org
Subject: Re: [PATCH 5/4] libbacktrace: improve getting debug information for loaded dlls
Date: Thu, 25 Apr 2024 22:14:52 +0200 [thread overview]
Message-ID: <25fd32ea-72aa-44b9-bbb5-1e58a446231f@hazardy.de> (raw)
In-Reply-To: <afe118eb-1e51-4ddb-9f50-5627834c2976@hazardy.de>
Am 15.03.2024 um 21:40 schrieb Björn Schäpers:
> Am 25.01.2024 um 23:04 schrieb Ian Lance Taylor:
>> On Thu, Jan 25, 2024 at 11:53 AM Björn Schäpers <gcc@hazardy.de> wrote:
>>>
>>> Am 23.01.2024 um 23:37 schrieb Ian Lance Taylor:
>>>> On Thu, Jan 4, 2024 at 2:33 PM Björn Schäpers <gcc@hazardy.de> wrote:
>>>>>
>>>>> Am 03.01.2024 um 00:12 schrieb Björn Schäpers:
>>>>>> Am 30.11.2023 um 20:53 schrieb Ian Lance Taylor:
>>>>>>> On Fri, Jan 20, 2023 at 2:55 AM Björn Schäpers <gcc@hazardy.de> wrote:
>>>>>>>>
>>>>>>>> From: Björn Schäpers <bjoern@hazardy.de>
>>>>>>>>
>>>>>>>> Fixes https://github.com/ianlancetaylor/libbacktrace/issues/53, except
>>>>>>>> that libraries loaded after the backtrace_initialize are not handled.
>>>>>>>> But as far as I can see that's the same for elf.
>>>>>>>
>>>>>>> Thanks, but I don't want a patch that loops using goto statements.
>>>>>>> Please rewrite to avoid that. It may be simpler to call a function.
>>>>>>>
>>>>>>> Also starting with a module count of 1000 seems like a lot. Do
>>>>>>> typical Windows programs load that many modules?
>>>>>>>
>>>>>>> Ian
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> Rewritten using a function.
>>>>>>
>>>>>> If that is commited, could you attribute that commit to me (--author="Björn
>>>>>> Schäpers <bjoern@hazardy.de>")?
>>>>>>
>>>>>> Thanks and kind regards,
>>>>>> Björn.
>>>>>
>>>>> I noticed that under 64 bit libraries loaded with LoadLibrary were missing.
>>>>> EnumProcessModules stated the correct number of modules, but did not fill the
>>>>> the HMODULEs, but set them to 0. While trying to investigate I noticed if I do
>>>>> the very same thing from main (in C++) I even got fewer module HMODULEs.
>>>>>
>>>>> So I went a different way. This detects all libraries correctly, in 32 and 64
>>>>> bit. The question is, if it should be a patch on top of the previous, or
>>>>> should
>>>>> they be merged, or even only this solution and drop the EnumProcessModules
>>>>> variant?
>>>>
>>>> Is there any reason to use both patches? Seems simpler to just use
>>>> this one if it works. Thanks.
>>>>
>>>> Ian
>>>
>>> This one needs the tlhelp32 header and its functions, which are (accoridng to
>>> the microsoft documentation) are only available since Windows XP rsp. Windows
>>> Server 2003.
>>>
>>> If that's no problem, and in my opinion it shouldn't be, then I can basically
>>> drop patch 4 and rebase this one.
>>
>> I don't see that as a problem. It seems like the patch will fall back
>> cleanly on ancient Windows and simply fail to pick up other loaded
>> DLLs. I think that is fine. I'll look for an updated patch. Thanks.
>>
>> Ian
>
> Attached is the combined version of the two patches, only implementing the
> variant with the tlhelp32 API.
>
> Tested on x86 and x86_64 windows.
>
> Kind regards,
> Björn.
A friendly ping.
next prev parent reply other threads:[~2024-04-25 20:14 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 10:54 [PATCH 1/4] libbacktrace: change all pc related variables to uintptr_t Björn Schäpers
2023-01-20 10:54 ` [PATCH 2/4] libbacktrace: detect executable path on windows Björn Schäpers
2023-01-23 23:00 ` Ian Lance Taylor
2023-01-24 13:11 ` Eli Zaretskii
2023-01-24 14:35 ` Ian Lance Taylor
2023-01-24 16:52 ` Eli Zaretskii
2023-01-24 17:58 ` Ian Lance Taylor
2023-01-24 18:11 ` Eli Zaretskii
2023-01-24 18:32 ` Ian Lance Taylor
2023-02-05 9:20 ` Björn Schäpers
2023-02-06 0:22 ` Ian Lance Taylor
2023-11-20 19:56 ` Björn Schäpers
2023-11-29 22:05 ` Ian Lance Taylor
2023-01-24 21:00 ` Björn Schäpers
2023-01-20 10:54 ` [PATCH 3/4] libbacktrace: work with aslr " Björn Schäpers
2023-01-20 13:39 ` Eli Zaretskii
2023-01-20 16:46 ` Gabriel Ravier
2023-01-20 19:19 ` Eli Zaretskii
2023-01-20 20:39 ` Gabriel Ravier
2023-01-21 4:05 ` Eli Zaretskii
2023-01-21 9:18 ` LIU Hao
2023-01-21 9:25 ` Eli Zaretskii
2023-01-21 10:47 ` Gabriel Ravier
2023-01-21 11:42 ` Eli Zaretskii
2023-11-20 19:57 ` Björn Schäpers
2023-11-20 20:07 ` Eli Zaretskii
2023-11-21 19:35 ` Björn Schäpers
2023-11-22 1:13 ` LIU Hao
2023-11-30 19:25 ` Ian Lance Taylor
2023-01-20 10:54 ` [PATCH 4/4] libbacktrace: get debug information for loaded dlls Björn Schäpers
2023-11-30 19:53 ` Ian Lance Taylor
2023-11-30 20:16 ` Eli Zaretskii
2024-01-02 23:12 ` Björn Schäpers
2024-01-04 22:33 ` [PATCH 5/4] libbacktrace: improve getting " Björn Schäpers
2024-01-06 22:15 ` [PATCH 6/4] libbacktrace: Add loaded dlls after initialize Björn Schäpers
2024-01-07 6:50 ` Eli Zaretskii
[not found] ` <4cb3a2a5-c0b3-40c8-b460-f21d65a9aea2@hazardy.de>
2024-01-07 14:46 ` Eli Zaretskii
2024-01-07 16:07 ` Björn Schäpers
2024-01-07 17:03 ` Eli Zaretskii
2024-01-09 20:02 ` Björn Schäpers
2024-01-10 12:34 ` Eli Zaretskii
2024-03-15 20:41 ` Björn Schäpers
2024-01-23 22:37 ` [PATCH 5/4] libbacktrace: improve getting debug information for loaded dlls Ian Lance Taylor
2024-01-25 19:53 ` Björn Schäpers
2024-01-25 22:04 ` Ian Lance Taylor
2024-03-15 20:40 ` Björn Schäpers
2024-04-25 20:14 ` Björn Schäpers [this message]
2024-04-28 18:16 ` Ian Lance Taylor
2024-05-02 19:23 ` Björn Schäpers
2024-05-03 22:27 ` Ian Lance Taylor
2024-01-23 21:24 ` [PATCH 4/4] libbacktrace: get " Björn Schäpers
2023-01-20 22:25 ` [PATCH 1/4] libbacktrace: change all pc related variables to uintptr_t Ian Lance Taylor
2023-01-23 20:17 ` Björn Schäpers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25fd32ea-72aa-44b9-bbb5-1e58a446231f@hazardy.de \
--to=gcc@hazardy.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=iant@golang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).