public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Christian Schneider <cschneider@radiodata.biz>
To: llvm-dev@lists.llvm.org, gcc@gcc.gnu.org
Cc: christian@ch-sc.de, premmers@radiodata.biz
Subject: enable_shared_from_this fails at runtime when inherited privately
Date: Thu, 29 Aug 2019 09:15:00 -0000	[thread overview]
Message-ID: <271ebc76-2e27-d4b4-6cd6-9f7a5c8ff7a1@radiodata.biz> (raw)

Hello,
I just discovered, that, when using enable_shared_from_this and 
inheriting it privately, this fails at runtime.
I made a small example:

#include <memory>
#include <boost/shared_ptr.hpp>
#include <boost/make_shared.hpp>
#include <boost/enable_shared_from_this.hpp>

#ifndef prefix
#define prefix std
#endif

class foo:
     prefix::enable_shared_from_this<foo>
{
public:
     prefix::shared_ptr<foo> get_sptr()
     {
         return shared_from_this();
     }
};

int main()
{
     auto a = prefix::make_shared<foo>();
     auto b = a->get_sptr();
     return 0;
}

This compiles fine, but throws a weak_ptr exception at runtime.
I'm aware, that the implementation requires, that 
enable_shared_from_this needs to be publicly inherited, but as a first 
time user, I had to find this out the hard way, as documentations (I 
use, ie. cppreference.com) don't mention it, probably because it's not a 
requirement of the standard.

On the other hand, if you compile the code with additional 
-Dprefix=boost (and needed boost stuff installed, of course), it gives a 
compiler error (
gcc: 'boost::enable_shared_from_this<foo>' is an inaccessible base of 'foo';
clang: error: cannot cast 'boost::shared_ptr<foo>::element_type' (aka 
'foo') to its private base class 'boost::enable_shared_from_this<foo>')

I'm think, it would be helpful, if the std implemantions also would fail 
at compile time already, and wanted to ask if this would be 
possible/feasible.

BR, Christian

compilers:
gcc-Version 9.2.0 (Gentoo 9.2.0 p1)
clang version 8.0.1 (tags/RELEASE_801/final) (used with both 
libstdc++.so.6 and libc++.so.1 (v8.0.1))

             reply	other threads:[~2019-08-29  9:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29  9:15 Christian Schneider [this message]
2019-08-29 10:07 ` Jonathan Wakely
2019-08-29 10:50   ` Christian Schneider
2019-08-29 11:43     ` Jonathan Wakely
2019-08-29 11:45       ` Jonathan Wakely
2019-08-29 14:46         ` Christian Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=271ebc76-2e27-d4b4-6cd6-9f7a5c8ff7a1@radiodata.biz \
    --to=cschneider@radiodata.biz \
    --cc=christian@ch-sc.de \
    --cc=gcc@gcc.gnu.org \
    --cc=llvm-dev@lists.llvm.org \
    --cc=premmers@radiodata.biz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).