From: Jeff Law <law@redhat.com>
To: "Eric Gallager" <egall@gwmail.gwu.edu>, "Martin Liška" <mliska@suse.cz>
Cc: "GCC Development" <gcc@gcc.gnu.org>,
"Jan Hubička" <honza.hubicka@gmail.com>,
"Uros Bizjak" <ubizjak@gmail.com>,
"H.J. Lu" <hjl.tools@gmail.com>,
"Jakub Jelinek" <jakub@redhat.com>
Subject: Re: [RFC] split of i386.c
Date: Tue, 12 Mar 2019 20:54:00 -0000 [thread overview]
Message-ID: <28098c4f-99a6-1004-90d4-82fa2f7eaa9c@redhat.com> (raw)
In-Reply-To: <CAMfHzOsh7gX8y7QRQJjwP-aGzch0VHM0UWqGqcko=N4zfu66JQ@mail.gmail.com>
On 3/12/19 2:50 PM, Eric Gallager wrote:
> On 3/12/19, Martin Liška <mliska@suse.cz> wrote:
>> Hi.
>>
>> I've thinking about the file split about quite some time, mainly
>> in context of PR84402. I would like to discuss if it's fine for
>> maintainers of the target to make such split and into which logical
>> components can the file be split?
>>
>> I'm suggesting something like:
>> - option-related and attribute-related stuff (i386-options.c - as seen in
>> patch)
>> - built-in related functions
>> - expansion/gen functions - still quite of lot of functions, would make
>> sense to split into:
>> - scalar
>> - vector
>> - prologue/epilogue, GOT, PLT, symbol emission
>> - misc extensions like STV, TLS, CET, retpolines, multiversioning, ..
>> - helpers - commonly used functions, print_reg, ix86_print_operand, ..
>>
>> I am volunteering to make the split, hopefully early in the next stage1.
>>
>> Thoughts?
>>
>> Thanks,
>> Martin
>>
>
> I'm not a maintainer, but just as an onlooker I highly support this
> move; i386.c is way too long as it is. 7 pieces sounds like a good
> number of new files to split it into, too.
I trust your judgment on where/how to split and fully support the goals
behind splitting. Uros is the key person you need to get on board.
jeff
next prev parent reply other threads:[~2019-03-12 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 15:08 Martin Liška
2019-03-12 20:50 ` Eric Gallager
2019-03-12 20:54 ` Jeff Law [this message]
2019-03-13 13:56 ` Uros Bizjak
[not found] ` <e1ec1b7b-851d-846e-c544-1f92fef0bd04@suse.cz>
2019-03-18 14:19 ` [WIP][RFC] " Martin Liška
2019-04-18 11:56 ` Jan Hubička
2019-04-23 10:12 ` Martin Liška
2019-03-13 12:55 ` [RFC] " David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28098c4f-99a6-1004-90d4-82fa2f7eaa9c@redhat.com \
--to=law@redhat.com \
--cc=egall@gwmail.gwu.edu \
--cc=gcc@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=honza.hubicka@gmail.com \
--cc=jakub@redhat.com \
--cc=mliska@suse.cz \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).