From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-170641-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 13644 invoked by alias); 12 Oct 2011 22:14:54 -0000
Received: (qmail 13630 invoked by uid 22791); 12 Oct 2011 22:14:54 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mga14.intel.com (HELO mga14.intel.com) (143.182.124.37)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Oct 2011 22:14:39 +0000
Received: from azsmga002.ch.intel.com ([10.2.17.35])  by azsmga102.ch.intel.com with ESMTP; 12 Oct 2011 15:14:38 -0700
X-ExtLoop1: 1
Received: from azsmsx601.amr.corp.intel.com ([10.2.121.193])  by AZSMGA002.ch.intel.com with ESMTP; 12 Oct 2011 15:14:38 -0700
Received: from azsmsx602.amr.corp.intel.com (10.2.121.201) by azsmsx601.amr.corp.intel.com (10.2.121.193) with Microsoft SMTP Server (TLS) id 8.2.255.0; Wed, 12 Oct 2011 15:14:38 -0700
Received: from azsmsx502.amr.corp.intel.com ([10.2.121.75]) by azsmsx602.amr.corp.intel.com ([10.2.121.201]) with mapi; Wed, 12 Oct 2011 15:14:38 -0700
From: "Iyer, Balaji V" <balaji.v.iyer@intel.com>
To: "'gcc@gcc.gnu.org'" <gcc@gcc.gnu.org>
Date: Thu, 13 Oct 2011 11:41:00 -0000
Subject: Question about default_elf_asm_named_section function
Message-ID: <2950715866004049A240A2F9BB410E7315F42971CC@azsmsx502.amr.corp.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
X-SW-Source: 2011-10/txt/msg00199.txt.bz2

Hello Everyone,
	This email is in reference to the "default_elf_asm_named_section" function=
 in the varasm.c file.=20

This function is defined like this:

void
default_elf_asm_named_section (const char *name, unsigned int flags,
                               tree decl ATTRIBUTE_UNUSED)


But, inside the function, there is this if-statement:


      if (HAVE_COMDAT_GROUP && (flags & SECTION_LINKONCE))
        {
          if (TREE_CODE (decl) =3D=3D IDENTIFIER_NODE)
            fprintf (asm_out_file, ",%s,comdat", IDENTIFIER_POINTER (decl));
          else
            fprintf (asm_out_file, ",%s,comdat",
                     IDENTIFIER_POINTER (DECL_COMDAT_GROUP (decl)));
        }


The decl is set with "ATTRIBUTE_UNUSED" but the if-statement is using "decl=
." Should we remove the attribute unused tag near the "tree decl" or is the=
 if-statement a deadcode that should never be ?

Thanks,

Balaji V. Iyer.