public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Thomas Koenig <tkoenig@netcologne.de>
To: "Martin Liška" <mliska@suse.cz>, "gcc mailing list" <gcc@gcc.gnu.org>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Subject: Re: Request for better syntax checking in lang.opt
Date: Sun, 23 Feb 2020 09:48:00 -0000	[thread overview]
Message-ID: <2f687302-18a8-ff34-bf54-1a8ebdb60ce5@netcologne.de> (raw)
In-Reply-To: <4a2af157-b21e-311f-3ff4-8dd432d67a05@suse.cz>

Hi Martin,

> I was able to write a sanity check for these kind of issues, but it does
> not resolve all similar issues for other keywords. It's not easy to do it.

Having looked at the origina awk code, I agree.  Maybe, in the long
term, a lex/yacc grammar with a monolithic C program to write out
the headers wold be more suitable.

Having said that, I think what you did is already quite valuable
and will save some gcc developers from a few prmature grey hairs :-)

So, I would recommend to commit as is.  Sanity checks do not have
to be perfect.

Thanks for taking this on!

Regards

	Thomas

  reply	other threads:[~2020-02-23  9:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20  7:29 Thomas Koenig
2020-02-20  8:16 ` Martin Liška
2020-02-20 18:08   ` Thomas Koenig
2020-02-21  9:43     ` Martin Liška
2020-02-23  9:48       ` Thomas Koenig [this message]
2020-03-02  9:49         ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f687302-18a8-ff34-bf54-1a8ebdb60ce5@netcologne.de \
    --to=tkoenig@netcologne.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).