public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeffrey A Law <law@cygnus.com>
To: Steven Parkes <parkes@sierravista.com>
Cc: egcs@cygnus.com
Subject: Re: configure --disable-threads
Date: Fri, 30 Oct 1998 07:31:00 -0000	[thread overview]
Message-ID: <3144.909732926@hurl.cygnus.com> (raw)
In-Reply-To: <199810271529.HAA03941@monterey.sierravista.com>

  In message < 199810271529.HAA03941@monterey.sierravista.com >you write:
  > It looks to me like --disable-threads has itself been disabled.  In
  > configure, it looks like $enable_threads is supposed to take on one of
  > three states but if you use --disable-threads or --enable-threads=no,
  > later code changes the value back to '' which causes it to default
  > which, in the case of hpux, brings in dce threads.
  > 
  > The patch below isn't clean, but it shows where the issue occurs.
  > 
  > *** configure.orig	Sat Oct 17 15:37:14 1998
  > --- configure	Sat Oct 17 15:53:00 1998
  > ***************
  > *** 825,831 ****
  >   if test "${enable_threads+set}" = set; then
  >     enableval="$enable_threads"
  >     if test x$enable_threads = xno; then
  > ! 	enable_threads=''
  >   fi
  >   else
  >     enable_threads=''
  > --- 825,831 ----
  >   if test "${enable_threads+set}" = set; then
  >     enableval="$enable_threads"
  >     if test x$enable_threads = xno; then
  > ! 	enable_threads='no'
  >   fi
  >   else
  >     enable_threads=''
I don't see how that can be happening.  Look at the case statement immediately
below the code in question.


enable_threads_flag=$enable_threads
# Check if a valid thread package
case x${enable_threads_flag} in
        x | xno)
                # No threads
                target_thread_file='single'
                ;;
        xyes)
                # default
                target_thread_file=''
                ;;
        xdecosf1 | xirix | xmach | xos2 | xposix | xpthreads | xsingle | \
        xsolaris | xwin32 | xdce | xvxworks)
                target_thread_file=$enable_threads_flag
                ;;
        *)
                echo "$enable_threads is an unknown thread package" 1>&2
                exit 1
                ;;
esac


It seems to me that without your patch x${enable_threads_flag} will expand
to "x", which should match the No threads clause.  If that's not working
correctly, you need to explain why.

Also, do not send patches to configure, it is a generated file from 
configure.in and other files.

jeff

  reply	other threads:[~1998-10-30  7:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-10-27  9:04 Steven Parkes
1998-10-30  7:31 ` Jeffrey A Law [this message]
1998-11-02 19:39   ` Steven Parkes
1998-11-03 23:34     ` Jeffrey A Law
1998-11-03 23:34       ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3144.909732926@hurl.cygnus.com \
    --to=law@cygnus.com \
    --cc=egcs@cygnus.com \
    --cc=parkes@sierravista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).