From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 4CCEA3858CD1 for ; Wed, 20 Mar 2024 15:34:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CCEA3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4CCEA3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710948860; cv=none; b=LV98jKdKXX3s9jXv7XfU1hu8P9zE3UmQL+2Q1+kZUbm4tPQcj4lCiROjwHc7rwAsKIyJ1s6z6RRzYCVviD7K8fdV8pWQbW5gL71K67M8A9crPNoHBSmPiFfm6+OJ+QvcqTGl9oOUj0zjSwF0cd5QWNjOdgrsYJ2BAWZoUuBbZ5U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710948860; c=relaxed/simple; bh=uUjknjxUdrKXfNbXXrFPtuzKyG07qKtBQRJyUtxKc4g=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=SPSPam5ViNQ/lMytalEaMWIGfKAQH76xEJFwnxB/CrLr0enIcsApawWprMeTZ2AmfuP8BL+enxo17zVLnuroXQkYag9iOJ/OmN/L0kb/L92NO5GOYDElZer6M230YK0O5myCXAM8T+noR0qmHbsFTNTLOXRBGwcQjFh87gRxa/E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1710948849; bh=uUjknjxUdrKXfNbXXrFPtuzKyG07qKtBQRJyUtxKc4g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=K/jdvDgifaUPC/gHUqDVyzUeoilPeOqdkS8bIIv65xP05n1qmwLTP+kRSQxzcBTiF hNwdh4iplialfZh7J/B2QFHavMyVAk2pDowNdbMJpXdsMtHXxrsHjDr4r38gLfxAiO mdp0dzzLZesWbMm/nbMfg4FbEEbQZXQwpXlxDTWg= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1F5931E030; Wed, 20 Mar 2024 11:34:08 -0400 (EDT) Message-ID: <33f72ef7-f990-437d-8fc4-dba08d7db24b@simark.ca> Date: Wed, 20 Mar 2024 11:34:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] add regenerate Makefile target Content-Language: fr To: Christophe Lyon Cc: binutils@sourceware.org, gdb@sourceware.org, gcc@gcc.gnu.org References: <20240313080237.1143034-1-christophe.lyon@linaro.org> <1eb529f2-3842-4090-a8e2-f713a28f2394@simark.ca> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/18/24 13:25, Christophe Lyon wrote: > Well the rule to regenerate Makefile.in (eg in in opcodes/) is a bit > more complex > than just calling automake. IIUC it calls automake --foreign it any of > *.m4 file from $(am__configure_deps) that is newer than Makefile.in > (with an early exit in the loop), does nothing if Makefile.am or > doc/local.mk are newer than Makefile.in, and then calls 'automake > --foreign Makefile' The rules looks complex because they've been generated by automake, this Makefile.in is not written by hand. And I guess automake has put `--foreign` there because foreign is used in Makefile.am: AUTOMAKE_OPTIONS = foreign no-dist But a simple call so `automake -f` (or `autoreconf -f`) just works, as automake picks up the foreign option from AUTOMAKE_OPTIONS, so a human or an external script who wants to regenerate things would probably just use that. > The bot I want to put in place would regenerate things as they are > supposed to be, then build and run the testsuite to make sure that > what is supposed to be committed would work (if the committer > regenerates everything correctly) For your job, would it be fine to just force-regenerate everything and ignore timestamps (just like the buildbot's autoregen job wants to do)? It would waste a few cycles, but it would be much simpler. Simon