From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 356D43858D28; Wed, 9 Nov 2022 14:45:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 356D43858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 711FD1FAC5; Wed, 9 Nov 2022 14:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1668005120; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OzWLjgUi22R0XUf99geArAIec8UJIGVXCyPp2vAQM9Q=; b=TlhRx+8ehwBM7S/jqBt+8dd1x0fEirwXvtaz1crtVJcArxnrhOeOERvgCUqJo5ZEKPz+8P DfU1a5I2HcOGN2+dYcs0l1iyBno8RNbpjYES8BW3w99zfy5u6CpmcebofBggodvh9nUTog WHDSbCYNwE9WDnM0+uf7wk02wAD6W/4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1668005120; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OzWLjgUi22R0XUf99geArAIec8UJIGVXCyPp2vAQM9Q=; b=EFCIdeu074umc+E40wuFEsrvj08UkhsDz85yoJTKRhgOJcqs7qITbXroIRf4Lwy/hFYXN1 gzE8jZhtRQmE1GAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4D6B3139F1; Wed, 9 Nov 2022 14:45:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id d4ZYEQC9a2NoNAAAMHmgww (envelope-from ); Wed, 09 Nov 2022 14:45:20 +0000 Message-ID: <39808e02-cf84-f9d2-3b55-4c161666e82a@suse.cz> Date: Wed, 9 Nov 2022 15:45:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Announcement: Porting the Docs to Sphinx - 9. November 2022 Content-Language: en-US To: Joseph Myers Cc: Xi Ruoyao , Sandra Loosemore , GCC Patches , GCC Development References: <9975b774-46d7-8870-fd92-498f5ec50ab4@suse.cz> <9ea57a95-fefe-81a3-848e-ede0893f5b61@suse.cz> <8198573b-89e2-a232-3e33-0e5c4153c112@suse.cz> <494cee6fc68c06e039f46c3d6f8331a32e81ab5e.camel@linuxfromscratch.org> <7bae16bc-9069-4964-a80e-7ebff82e007e@suse.cz> <2a4347ab-40a1-2afc-f48c-6d8290afb7c6@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/20/22 18:43, Joseph Myers wrote: > On Thu, 20 Oct 2022, Martin Liška wrote: > >>> Also, but not strictly part of the release issue: >>> >>> (d) Builds with missing or old Sphinx should work regardless of whether >>> such files are in the source directory - but if they aren't in the source >>> directory, the effect of missing or old Sphinx (detected at configure >>> time) should be to disable building and installing documentation. >> >> All right Joseph, is it something you're willing to help me once we start >> using Sphinx? Apparently, there will be many consequent steps after we switch. > > Sure, but most of the conditionals are *already* present, just need > updating as part of the Sphinx transition. E.g. gcc/Makefile.in has > BUILD_INFO and GENERATED_MANPAGES conditionals based on configure tests > for whether relevant tools are present and new enough; the rules for > $(DESTDIR)$(infodir)/%.info quietly allow the info files not to be > present, so installing also works without the info files or tools to build > them, and the rules for installing man pages similarly ignore errors; and > there are srcinfo and srcman rules, enabled based on @GENINSRC@, to copy > those built files to the source directory, which are what's used when > --enable-generated-files-in-srcdir is used as part of building a release > tarball. > > The main thing I've suggested that I think may actually be new is an error > for trying to build a release tarball without new-enough Sphinx (I think > the current rules would quietly not copy info / man pages to the source > directory if build tools were missing - but having those tools missing > when building a release tarball is much less likely than not having > new-enough Sphinx). > Hello Joseph. So the transition is done and I would to ask you Joseph for help with the following 2 items: 1) not synchronized content among lib*/Makefile.in and lib*/Makefile.am. Apparently, I modified the generated Makefile.in file with the rules like: doc/info/texinfo/libitm.info: $(SPHINX_FILES) + if [ x$(HAS_SPHINX_BUILD) = xhas-sphinx-build ]; then \ make -C $(srcdir)/../doc info SOURCEDIR=$(abs_srcdir)/doc BUILDDIR=$(abs_doc_builddir)/info SPHINXBUILD=$(SPHINX_BUILD); \ else true; fi Can you please modify Makefile.am in the corresponding manner and re-generate Makefile.in? 2) Adding proper support --enable-generated-files-in-srcdir in gcc_release: As mentioned above in the quoted email. Thanks in advance, Martin