Another bootstrap error: fixinc/gnu-regex.c and _nl_msg_cat_cntr

Another bootstrap error: fixinc/gnu-regex.c and _nl_msg_cat_cntr

[Gerald Pfeifer]

Yet another bootstrap error, this time in fixinc (which has never been
broken for me before).

Seen on i386-unknown-freebsd4.2 for a plain bootstrap with
./configure --enable-languages=c.

gcc -c -DIN_GCC -g   -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long -I. -I.. -I/sw/test/gcc/gcc/gcc/fixinc -I/sw/test/gcc/gcc/gcc/fixinc/.. -I/sw/test/gcc/gcc/gcc/fixinc/../config -I/sw/test/gcc/gcc/gcc/fixinc/../../include /sw/test/gcc/gcc/gcc/fixinc/gnu-regex.c
/sw/test/gcc/gcc/gcc/fixinc/gnu-regex.c:158: warning: function declaration isn't a prototype
gcc -c -DIN_GCC -g   -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long -I. -I.. -I/sw/test/gcc/gcc/gcc/fixinc -I/sw/test/gcc/gcc/gcc/fixinc/.. -I/sw/test/gcc/gcc/gcc/fixinc/../config -I/sw/test/gcc/gcc/gcc/fixinc/../../include /sw/test/gcc/gcc/gcc/fixinc/fixlib.c
gcc -DIN_GCC -g   -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long -I. -I.. -I/sw/test/gcc/gcc/gcc/fixinc -I/sw/test/gcc/gcc/gcc/fixinc/.. -I/sw/test/gcc/gcc/gcc/fixinc/../config -I/sw/test/gcc/gcc/gcc/fixinc/../../include  -o fixincl fixincl.o fixtests.o fixfixes.o server.o procopen.o gnu-regex.o fixlib.o ../../libiberty/libiberty.a
gnu-regex.o: In function `re_compile_pattern':
/sw/test/gcc/gcc/gcc/fixinc/gnu-regex.c(.text+0x7fee): undefined reference to `_nl_msg_cat_cntr'
/sw/test/gcc/gcc/gcc/fixinc/gnu-regex.c(.text+0x8015): undefined reference to `dcgettext__'
/sw/test/gcc/gcc/gcc/fixinc/gnu-regex.c(.text+0x8024): undefined reference to `_nl_msg_cat_cntr'
/sw/test/gcc/gcc/gcc/fixinc/gnu-regex.c(.text+0x8055): undefined reference to `dcgettext__'
gnu-regex.o: In function `regerror':
/sw/test/gcc/gcc/gcc/fixinc/gnu-regex.c(.text+0x83f2): undefined reference to `_nl_msg_cat_cntr'
/sw/test/gcc/gcc/gcc/fixinc/gnu-regex.c(.text+0x8419): undefined reference to `dcgettext__'
/sw/test/gcc/gcc/gcc/fixinc/gnu-regex.c(.text+0x8428): undefined reference to `_nl_msg_cat_cntr'
/sw/test/gcc/gcc/gcc/fixinc/gnu-regex.c(.text+0x8459): undefined reference to `dcgettext__'
gmake[3]: *** [full-stamp] Error 1
gmake[3]: Leaving directory `/files/pfeifer/OBJ-1214-10:41/gcc/fixinc'
gmake[2]: *** [fixinc.sh] Error 2
gmake[2]: Leaving directory `/files/pfeifer/OBJ-1214-10:41/gcc'
gmake[1]: *** [stage_a] Error 2
gmake[1]: Leaving directory `/files/pfeifer/OBJ-1214-10:41/gcc'

Gerald

Re: Another bootstrap error: fixinc/gnu-regex.c and _nl_msg_cat_cntr

[Richard Earnshaw]

> Yet another bootstrap error, this time in fixinc (which has never been
> broken for me before).
> 
> Seen on i386-unknown-freebsd4.2 for a plain bootstrap with
> ./configure --enable-languages=c.

The same is happening on solaris-2.5.1.

This is because the #include of auto-host.h has now been moved before the 
#ifdef ENABLE_NLS, so gnu-regex.c is now nls enabled.  Unfortunately, the 
makefile makes no attempt to link in ../intl, despite the comment in the 
code saying that it does :-(

Not sure what the fix is, off-hand -- if you revert r1.11->r1.10 in 
gnu-regex.c, you can get things building again for now.

R.

Re: Another bootstrap error: fixinc/gnu-regex.c and _nl_msg_cat_cntr

[Bruce Korb]

Gerald Pfeifer wrote:
> 
> Yet another bootstrap error, this time in fixinc (which has never been
> broken for me before).

I think I get to claim my share, tho mostly a couple years ago...

> Seen on i386-unknown-freebsd4.2 for a plain bootstrap with
> ./configure --enable-languages=c.

Yeah.  NLS stuff, of which I know nothing at all.
I assume it does not happen without the --enable  :-(.
If someone has a proper regex in libiberty, then
we can pass the problem off  :-).

 - Bruce

Re: Another bootstrap error: fixinc/gnu-regex.c and _nl_msg_cat_cntr

[Bruce Korb]

Richard Earnshaw wrote:
> 
> > Yet another bootstrap error, this time in fixinc (which has never been
> > broken for me before).
> >
> > Seen on i386-unknown-freebsd4.2 for a plain bootstrap with
> > ./configure --enable-languages=c.
> 
> The same is happening on solaris-2.5.1.
> 
> This is because the #include of auto-host.h has now been moved before the
> #ifdef ENABLE_NLS, so gnu-regex.c is now nls enabled.  Unfortunately, the
> makefile makes no attempt to link in ../intl, despite the comment in the
> code saying that it does :-(
> 
> Not sure what the fix is, off-hand -- if you revert r1.11->r1.10 in
> gnu-regex.c, you can get things building again for now.

It was not happening for me.  But I was on another box.
The easiest is to just move the include of auto-host.h down
to after the #ifdef ENABLE_NLS.  I made this change after noting
the compiler complaining about _GCC_... being defined twice.
Since auto-host.h does not protect against pre-definition
and automatically defines it itself, I looked aroung at the
#include context for auto-host.h in other sources.  This looked
safe, but was not.  So, I think the right fix is to put it back
where I got it and have auto-host.h either #undef the _GCC_...
thingey first or conditionally #define it.  Or figure out how to
use regex out of libiberty  :-).

Re: Another bootstrap error: fixinc/gnu-regex.c and _nl_msg_cat_cntr

[Richard Earnshaw]

bkorb@sco.COM said:
> It was not happening for me.  But I was on another box. 

Well on some systems, all the intl support is already in libc, so ../intl 
would be an empty target -- but not for everybody.

Anyway, I seems to have been decided that we don't want intl for this 
code; that's fine by me.

R.