public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Toon Moene <moene@knmi.nl>
To: David Edelsohn <dje@watson.ibm.com>
Cc: "Billinghurst, David (CRTS)" <David.Billinghurst@riotinto.com>,
	gcc@gcc.gnu.org
Subject: Re: Plan for bug-fixing g77-3.1.
Date: Wed, 30 Jan 2002 07:48:00 -0000	[thread overview]
Message-ID: <3C57B081.96CD6CC1@knmi.nl> (raw)
In-Reply-To: <200201300422.XAA27534@makai.watson.ibm.com>

David Edelsohn wrote:

> >>>>> Billinghurst, David (CRTS) writes:

> DavidB> I agree with your analysis that, in isolation, swapping BIT_SIZE
> DavidB> and BITEST in intrin.def only paper over the cracks.
> DavidB> However, this patch is required in conjunction with Toon's patch to
> DavidB> use strcasecmp when comparing intrinsic names.
> 
>         This only fixes the testcase example.  There are other intrinsics
> with underscores in the name.

While that is true, the BITEST/BIT_SIZE couple is special in that the
first differing character is a letter in one and an underscore in the
other entry.  This means that exactly *those* entries will sort
differently when sorted "upper cased" vs. sorted "lower case".

I should have been more careful with strcasecmp (the man page explicitly
states that the case-insensitive compare will be effected by converting
both names to lower case - which is just the wrong way for solving this
problem).

I'm now testing a patch that uses a specially written "compare upper
case", that will convert the would-be-intrinsic-name to upper case when
comparing it with the first of the three entries from the table. 
AFAICS, this should correct the problem.

--
Toon Moene, KNMI, PO Box 201, 3730 AE De Bilt, The Netherlands.
Tel. +31302206443, Fax +31302210407,  e-mail moene@knmi.nl
URL: http://www.knmi.nl/hirlam

  reply	other threads:[~2002-01-30  8:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-29 22:57 Billinghurst, David (CRTS)
2002-01-29 23:29 ` David Edelsohn
2002-01-30  7:48   ` Toon Moene [this message]
2002-01-30  8:59     ` Correct comparison to the intrinsics table, was: " Toon Moene
  -- strict thread matches above, loose matches on Subject: below --
2002-02-05 14:24 Billinghurst, David (CRTS)
2002-02-05 15:04 ` Toon Moene
2002-01-30  0:20 Billinghurst, David (CRTS)
2002-01-30  3:32 ` David Edelsohn
2002-01-29 20:22 Billinghurst, David (CRTS)
2002-01-29 22:21 ` David Edelsohn
2002-01-29 11:33 Toon Moene
2002-01-29 12:02 ` David Edelsohn
2002-01-27  9:49 Billinghurst, David (CRTS)
2002-01-27 13:01 ` Toon Moene
2002-01-27 13:17   ` Toon Moene
2002-01-22  7:27 Reichelt
2002-01-22  7:03 Reichelt
2002-01-21 14:47 Toon Moene
2002-01-25 18:08 ` Toon Moene

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C57B081.96CD6CC1@knmi.nl \
    --to=moene@knmi.nl \
    --cc=David.Billinghurst@riotinto.com \
    --cc=dje@watson.ibm.com \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).