From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11436 invoked by alias); 25 Jul 2002 21:49:18 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 11423 invoked from network); 25 Jul 2002 21:49:15 -0000 Received: from unknown (HELO ns2.uk.superh.com) (193.128.105.170) by sources.redhat.com with SMTP; 25 Jul 2002 21:49:15 -0000 Received: from sh-uk-ex01.uk.w2k.superh.com (sh-uk-ex01 [192.168.16.17]) by ns2.uk.superh.com (8.11.6+Sun/8.11.6) with ESMTP id g6PLfvK01083; Thu, 25 Jul 2002 22:41:57 +0100 (BST) Received: from superh.com ([192.168.17.40]) by sh-uk-ex01.uk.w2k.superh.com with Microsoft SMTPSVC(5.0.2195.4905); Thu, 25 Jul 2002 22:48:16 +0100 Message-ID: <3D407219.5F682132@superh.com> Date: Thu, 25 Jul 2002 23:23:00 -0000 From: Joern Rennecke Organization: SuperH UK Ltd. X-Accept-Language: en MIME-Version: 1.0 To: Momchil Velikov CC: gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: Unreviewed patch / {PATCH] Do not override configure decision about inhibit_libc References: <87n0sgqlqu.fsf@fadata.bg> <3D3FCD3F.CEE12605@superh.com> <87d6tchyes.fsf@fadata.bg> <3D3FDC0F.77C915D0@superh.com> <87y9c0giej.fsf@fadata.bg> <3D3FF1EC.39BA039A@superh.com> <87it33kjqa.fsf@fadata.bg> Content-Type: multipart/mixed; boundary="------------FE2AD3540A47D37E8D1BE976" X-OriginalArrivalTime: 25 Jul 2002 21:48:16.0561 (UTC) FILETIME=[FBABEA10:01C23424] X-SW-Source: 2002-07/txt/msg01254.txt.bz2 This is a multi-part message in MIME format. --------------FE2AD3540A47D37E8D1BE976 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-length: 794 Momchil Velikov wrote: > Joern> Is there a demand for this configuration? In that case, we should > Joern> have something more fine-grained that inhibit_libc, which suppresses > Joern> the profiling support along with eprintf. > > I'd think disabling profiling in the environments, which do not > support stdio is prefferable to disabling the use of GCC in these > environments. Yes, but currently inhibit_libc is set automatically for all newlib toolchains, so if we disabled profiling using inhibit_libc, profiling would be disabled altogether for newlib toolchains. We have to get rid of this automatic setting of inhibit_libc so that inhibit_libc actually means somehing again. -- -------------------------- SuperH 2430 Aztec West / Almondsbury / BRISTOL / BS32 4AQ T:+44 1454 462330 --------------FE2AD3540A47D37E8D1BE976 Content-Type: text/plain; charset=us-ascii; name="dont-inhibit-newlibc" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="dont-inhibit-newlibc" Content-length: 2375 Thu Jul 25 22:40:05 2002 J"orn Rennecke * configure.in (inhibit_libc): For newlib, set to -Dinhibit_eprintf. * libgcc2.c (__eprintf): Also inhibited by inhibit_eprintf. Index: configure.in =================================================================== RCS file: /cvs/gcc/gcc/gcc/configure.in,v retrieving revision 1.610 diff -p -r1.610 configure.in *** configure.in 14 Jul 2002 01:59:13 -0000 1.610 --- configure.in 25 Jul 2002 21:39:58 -0000 *************** fi *** 1144,1157 **** # have its own set of headers then define # inhibit_libc ! # If this is using newlib, then define inhibit_libc in LIBGCC2_CFLAGS. ! # This prevents libgcc2 from containing any code which requires libc ! # support. inhibit_libc= ! if [test x$host != x$target] && [test x$with_headers = x]; then ! inhibit_libc=-Dinhibit_libc else ! if [test x$with_newlib = xyes]; then inhibit_libc=-Dinhibit_libc fi fi --- 1144,1157 ---- # have its own set of headers then define # inhibit_libc ! # If this is using newlib, then define inhibit_libc in LIBGCC2_CFLAGS to ! # -Dinhibit_eprintf. We should not be using __eprintf because newlib ! # has its own version of assert.h inhibit_libc= ! if [test x$with_newlib = xyes]; then ! inhibit_libc=-Dinhibit_eprintf else ! if [test x$host != x$target] && [test x$with_headers = x]; then inhibit_libc=-Dinhibit_libc fi fi Index: libgcc2.c =================================================================== RCS file: /cvs/gcc/gcc/gcc/libgcc2.c,v retrieving revision 1.144 diff -p -r1.144 libgcc2.c *** libgcc2.c 22 Jul 2002 00:15:49 -0000 1.144 --- libgcc2.c 25 Jul 2002 21:39:58 -0000 *************** __gcc_bcmp (const unsigned char *s1, con *** 1214,1220 **** for binary backward compatibility. Note that it is not included in the shared version of libgcc. */ #ifdef L_eprintf ! #ifndef inhibit_libc #undef NULL /* Avoid errors if stdio.h and our stddef.h mismatch. */ #include --- 1214,1220 ---- for binary backward compatibility. Note that it is not included in the shared version of libgcc. */ #ifdef L_eprintf ! #if ! defined (inhibit_libc) && ! defined (inhibit_eprintf) #undef NULL /* Avoid errors if stdio.h and our stddef.h mismatch. */ #include --------------FE2AD3540A47D37E8D1BE976--