public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* RFC: Odd code in sched-deps.c:compute_forward_dependences
@ 2003-02-03 23:10 Graham Stott
  2003-02-03 23:23 ` Graham Stott
  0 siblings, 1 reply; 2+ messages in thread
From: Graham Stott @ 2003-02-03 23:10 UTC (permalink / raw)
  To: gcc

Hi

While look thru the scheduling code I've spotted an odd looking
bit of code which looks like it's got a typo.


void
compute_forward_dependences (head, tail)
      rtx head, tail;
{
   .....

       for (link = LOG_LINKS (insn); link; link = XEXP (link, 1))
         {
           rtx x = XEXP (link, 0);
           rtx new_link;

           if (x != XEXP (link, 0))
             continue;

As written the x != XEXP (link, 0) test can never be true due to the
initial assignment to x.

Do anyone have any idea what's up?

Graham

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: RFC: Odd code in sched-deps.c:compute_forward_dependences
  2003-02-03 23:10 RFC: Odd code in sched-deps.c:compute_forward_dependences Graham Stott
@ 2003-02-03 23:23 ` Graham Stott
  0 siblings, 0 replies; 2+ messages in thread
From: Graham Stott @ 2003-02-03 23:23 UTC (permalink / raw)
  To: Graham Stott; +Cc: gcc

All,

Graham Stott wrote:

> Do anyone have any idea what's up?
>  

Answering my own Q :-)

It looks like the test is now redundant followings vald's
28-01-01 scheduling patch which removed group_leader.

Graham



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-02-03 23:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-03 23:10 RFC: Odd code in sched-deps.c:compute_forward_dependences Graham Stott
2003-02-03 23:23 ` Graham Stott

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).