Re: pthread related breakage (mainline)

Re: pthread related breakage (mainline)

[Giovanni Bajo]

Giovanni Bajo <giovannibajo@libero.it> wrote:

>> 2003-10-09  Nathanael Nerode  <neroden@gcc.gnu.org>
>>
>>     * config.gcc: Remove redundant thread_file setting clauses for
>>     various *-*-linux* targets.
>
> I reverted this patch and I'm bootstrapping now. For reference, it's:
> http://gcc.gnu.org/ml/gcc-patches/2003-10/msg00715.html
> cvs diff -u -r 1.394 -r 1.395 config.gcc | patch -R
>
> Let's see if it helps.

Alas it doesn't. I also reverted this:

2003-10-08  Nathanael Nerode  <neroden@gcc.gnu.org>

    * config.gcc: Don't accept --enable-threads=pthreads.  Clean
    up related case statements.
    * configure.in: Don't accept --enable-threads=pthreads,
    decosf1, mach, or os2 (none of which work anyway).  Alphabetize
    supported thread files in case clause.
    * configure: Regenerate.

and bootstrap is still broken. I'll try reverting also the third Paolo
suggested now.

Giovanni Bajo

Re: pthread related breakage (mainline)

[Paolo Carlini]

Giovanni Bajo wrote:

>and bootstrap is still broken. I'll try reverting also the third Paolo
>suggested now.
>  
>
Hi Giovanni. Consider, however, that I'm not a configury expert and 
didn't actually analyze the content of those patches. Perhaps, it's 
something more recent, perhaps it's a complex interaction between old 
and recent commits. I can only tell one thing for sure: nothing threads 
related changed in the libstdc++-v3 directory and if  I revert the 
compiler to three days ago:

    cvs -z9 update -D "3 days ago"

and then the library:

    cvs -z9 update -A

everything is OK, just done on x86_64.

Paolo.

Re: pthread related breakage (mainline)

[Paolo Carlini]

Paolo Carlini wrote:

>    cvs -z9 update -D "3 days ago"

Also OK for -D "2 days ago"...

Now checking -D "1 day ago".

Paolo.

Re: pthread related breakage (mainline)

[Paolo Carlini]

Paolo Carlini wrote:

> Now checking -D "1 day ago".

BROKEN!

Now checking -D "36 hours ago".

Paolo.

Re: pthread related breakage (mainline)

[Janis Johnson]

On Mon, Dec 08, 2003 at 07:49:00PM +0100, Paolo Carlini wrote:
> Paolo Carlini wrote:
> 
> > Now checking -D "1 day ago".
> 
> BROKEN!
> 
> Now checking -D "36 hours ago".

Sounds like you need automated regression hunting tools.

Janis

Culprits... (Re: pthread related breakage (mainline))

[Paolo Carlini]

Janis Johnson wrote:

> Sounds like you need automated regression hunting tools.

Yes ;) Could you possibly help?

But we are already quite close: the breakage happened between 36 and
24 hours ago, and the candidates are the changes to gcc/aclocal.m4,
gcc/configure and gcc/configure.in that happened in that time span.

Just a couple of commits: can you help pinpointing the exact one?

2003-12-07 Nathanael Nerode <neroden@gcc.gnu.org>

    * configure.in, aclocal.m4: Revert to pre-2.5x conversion status.
    * configure: Regenerate with autoconf 2.13.

    * configure.in: Replace AC_INIT, AC_OUTPUT, AC_CANONICAL_SYSTEM
    with modern equivalents.
    * configure: Regenerate.

    * configure.in: Replace gcc_AC_CHECK_TYPE with AC_CHECK_TYPE.
    * aclocal.m4 (gcc_AC_CHECK_TYPE): Remove.
    * configure: Regenerate.

    * configure: Regenerate with (preferred) autoconf 2.57.
    * doc/install.texi: Note that 'gcc' is now a 2.57 directory.

2003-12-07 Nathanael Nerode <neroden@gcc.gnu.org>

    * configure.in: Make minimum necessary changes for autoconf 2.5x.
    * aclocal.m4: Make minimum necessary changes for autoconf 2.5x.
    * configure: Regenerate with autoconf 2.58.

Thanks!
Paolo.

Re: Culprits... (Re: pthread related breakage (mainline))

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

Paolo Carlini <pcarlini@unitus.it> writes:

> Janis Johnson wrote:
>
>> Sounds like you need automated regression hunting tools.
>
> Yes ;) Could you possibly help?
>
> But we are already quite close: the breakage happened between 36 and
> 24 hours ago, and the candidates are the changes to gcc/aclocal.m4,
> gcc/configure and gcc/configure.in that happened in that time span.
>
> Just a couple of commits: can you help pinpointing the exact one?

I gues it's this change but I'm double checking this right now...

--- ChangeLog   7 Dec 2003 14:13:53 -0000       2.1950
+++ ChangeLog   7 Dec 2003 16:12:26 -0000       2.1951
@@ -1,5 +1,8 @@
 2003-12-07  Nathanael Nerode  <neroden@gcc.gnu.org>
 
+       * configure.in, aclocal.m4: Revert to pre-2.5x conversion status.
+       * configure: Regenerate with autoconf 2.13.
+
        * configure.in: Replace AC_INIT, AC_OUTPUT, AC_CANONICAL_SYSTEM
        with modern equivalents.
        * configure: Regenerate.

So, somehow the reversion or the regeneration was not ok.

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Culprits... (Re: pthread related breakage (mainline))

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

Andreas Jaeger <aj@suse.de> writes:

> I gues it's this change but I'm double checking this right now...
>
> --- ChangeLog   7 Dec 2003 14:13:53 -0000       2.1950
> +++ ChangeLog   7 Dec 2003 16:12:26 -0000       2.1951
> @@ -1,5 +1,8 @@
>  2003-12-07  Nathanael Nerode  <neroden@gcc.gnu.org>
>  
> +       * configure.in, aclocal.m4: Revert to pre-2.5x conversion status.
> +       * configure: Regenerate with autoconf 2.13.
> +
>         * configure.in: Replace AC_INIT, AC_OUTPUT, AC_CANONICAL_SYSTEM
>         with modern equivalents.
>         * configure: Regenerate.
>
> So, somehow the reversion or the regeneration was not ok.

Sorry Nerode for blaming your change - it was Giovanni's patch that
happened also in that range and I was too focused on this :-(

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]