From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 158DD39DC4E2 for ; Fri, 18 Jun 2021 11:26:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 158DD39DC4E2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: 9ctVl71+3RB13xe/uNXeAPaZyPJciDMYuGpNRCPryhLOjat7aR71Dp2+WXEVV3b7PvTasajAK4 bDcoXwg0GsRa5iJWrS9e+loaN5EXeforMXRXticMKCDH9QGIm5/q2MGgLzB+HKjtvohzY/5y+o R1yyrLwI7NRqnhewEMoeZudy+56PmzTNBNvtAIBFZbC4yxZj3AS+M12aoBxwlayNyGSZVYgGnH a2F62HR0bD2jLxnnhnTpha9G+L0OJQi/RRp/FNmQkBWMlCscOw4lO/JtjsewU87Ckwk6Dl9w9r KE4= X-IronPort-AV: E=Sophos;i="5.83,283,1616486400"; d="scan'208";a="62740302" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 18 Jun 2021 03:26:00 -0800 IronPort-SDR: Gipb2DPcEOysrTPyrkaF+NrHd4+UxXqIVzq+Cm8gP5pXm8cJgQu/DWqbugLvFUbOeutekbPOS/ edxRP88d7/SmksMMugbe4H140bQ2wPdM2XAr/BBKk7M10D3m0L2Pbv584dlhU71pDHmDI5WrVw laC2fsxNQ1vEWxaAGfXStbkpQ6ZzhugIMKteJK60QT7E2s5fq1XgEYq1ukDxqpLYdIdpDyJ8hU DDmUKmV4VvpUjhUO99jTdRRBGiAD96myBekNQUHFNyRfuwk2lNqY3ZxbIwQckkrk3wcoEKVQ2T jdc= Subject: Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog) To: Jonathan Wakely CC: Richard Earnshaw , Jakub Jelinek , Joseph Myers , =?UTF-8?Q?Martin_Li=c5=a1ka?= , gcc Mailing List References: <71b4a023-efb2-6c6a-9ced-93cce7c96540@gmail.com> <013d6727-4008-b4b5-b793-c782a5ba8e10@redhat.com> <916af0f3-0877-e977-6b6c-899edec8e706@foss.arm.com> <20210617172129.GH7746@tucnak> <16f70de7-8324-e249-dbd8-605022066d12@foss.arm.com> <070f57d5-1496-50f4-1144-3ff2e75a4460@codesourcery.com> From: Tobias Burnus Message-ID: <3eaccd30-3c1d-8f62-6382-e3ceb1b4bad2@codesourcery.com> Date: Fri, 18 Jun 2021 13:25:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 11:26:03 -0000 On 18.06.21 13:10, Jonathan Wakely wrote: > On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: >> PR c++/12394 - internal compiler error: in write_type, at cp/mangle.c:15= 17 >> PR fortran/100123 - -ftree-fre gives incorrect result in subroutine with= array declared as length 1 >> PR c++/12394 >> PR fortran/100123 > Now that we put these PR cmpt/nnnn lines before the xxx/ChangeLog > entries, is there any reason to indent them with a TAB? My understanding with the PR before vs. after the xxx/ChangeLog is that if you put them before, they apply to all changelog entries and if you put them afterward, it only only applies to the those ChangeLog files for which they have been mentioned. (But I also might have misread the code/were misguided by the var names.) And when manually creating the changelog from scratch, they still often end up after the ChangeLog line. But otherwise, I am not attached to the tab. Just one thing: It might be slightly inconsistent to require the tab after the xxx/ChangeLog line but not before that line. And I think a tab should be used after the xxx/ChangeLog line. > If we didn't require the TAB before them, then the lines added by -p > would serve the same purpose, and we wouldn't need to repeat them > > So instead of requiring "^\tPR .*/\d+$" for the PR entry, require > "^\t?PR ([^/]+)/\d+" I think we should require either ($|\s) after the PR number but otherwise, it works for me. I am sure that Martin Sebor will like this change as he currently writes changelogs (see in this thread or) like the following one. In that sense, there would be a precedent in terms of actual usage. ---------- Teach compute_objsize about placement new [PR100876]. Resolves: PR c++/100876 - -Wmismatched-new-delete should understand placement new whe= n it's not inlined gcc/ChangeLog: PR c++/100876 ---------- Tobias PS: My feeling is that you like the proposed mklog patch :-) ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnchen R= egistergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas H= eurung, Frank Th=C3=BCrauf