Phil Edwards wrote: > > Things dealing with libstdc++-v3 should also be sent to that list. Thanks. > > I'll leave the guts of the patch to a MIPS maintainer to approve, but here > are some things you'll need to change: > > > - _Atomic_word __result, __tmp; > > + _Atomic_word __result, __tmp, temp; > > The name must have two leading underscores, so it would have to be __temp, > not temp. Likewise for the second function. > > Please consider renaming these to something more descriptive. We know > they're temporary. :-) We don't know what they're used for without > studying the assembly. (Feel free to rename tmp as well.) Renamed temp to __addr, which should be more descriptive. Renamed __tmp to __sum, since it is the sum of the __mem value and __val. Also added a changelog entry, which I'd forgotten. > > + "la %3,%2\n\t" > > + "ll %0,0(%3)\n\t" > > + "addu %1,%5,%0\n\t" > > + "sc %1,0(%3)\n\t" > > Watch the extra space in the first line. (Might as well get the cosmetic > aspects right from the beginning.) Replaced spaces with a tab. -- Michael Eager eager@mvista.com 408-328-8426 MontaVista Software, Inc. 1237 E. Arques Ave., Sunnyvale, CA 94085