Error building 3.3.4 on i686-cygwin.

Error building 3.3.4 on i686-cygwin.

[Bauke van Dijk]

While building on i686-cygwin I get

gcc   -g  -DIN_GCC   -W -Wall -Wwrite-strings -Wstrict-prototypes 
-Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long 
-DHAVE_CONFIG_H   -DCYGWIN_CROSS_DIR=\"/usr/local/i686-pc-cygwin\" -I. 
-I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/config 
-I../../gcc/gcc/../include \
   -DSTANDARD_STARTFILE_PREFIX=\"../../../\" 
-DSTANDARD_EXEC_PREFIX=\"/usr/local/lib/gcc-lib/\" 
-DDEFAULT_TARGET_VERSION=\"3.3.4\" 
-DDEFAULT_TARGET_MACHINE=\"i686-pc-cygwin\" 
-DSTANDARD_BINDIR_PREFIX=\"/usr/local/bin/\" 
-DTOOLDIR_BASE_PREFIX=\"../../../../\"  `test "X${SHLIB_LINK}" = "X" || 
test "yes" != "yes" || echo "-DENABLE_SHARED_LIBGCC"` `test 
"X${SHLIB_MULTILIB}" = "X" || echo "-DNO_SHARED_LIBGCC_MULTILIB"` \
   -c ../../gcc/gcc/gcc.c -o gcc.o)
../../gcc/gcc/gcc.c:672: warning: traditional C rejects string concatenation
../../gcc/gcc/gcc.c:672: warning: string length `735' is greater than 
the length `509' ISO C89 compilers are required to support
../../gcc/gcc/gcc.c:679: warning: traditional C rejects string concatenation
../../gcc/gcc/gcc.c:683: warning: traditional C rejects string concatenation
../../gcc/gcc/gcc.c:706: warning: string length `524' is greater than 
the length `509' ISO C89 compilers are required to support
../../gcc/gcc/gcc.c:853: warning: string length `523' is greater than 
the length `509' ISO C89 compilers are required to support
In file included from specs.h:2,
                  from ../../gcc/gcc/gcc.c:883:
../../gcc/gcc/cp/lang-specs.h:45: warning: traditional C rejects string 
concatenation
../../gcc/gcc/cp/lang-specs.h:45: warning: string length `735' is 
greater than the length `509' ISO C89 compilers are required to support
In file included from specs.h:5,
                  from ../../gcc/gcc/gcc.c:883:
../../gcc/gcc/objc/lang-specs.h:28: warning: string length `546' is 
greater than the length `509' ISO C89 compilers are required to support
../../gcc/gcc/gcc.c:1437: warning: string length `733' is greater than 
the length `509' ISO C89 compilers are required to support
../../gcc/gcc/gcc.c: In function `process_command':
../../gcc/gcc/gcc.c:3609: warning: assignment of read-only location
../../gcc/gcc/gcc.c:3611: warning: assignment of read-only location

later in stage 1

stage1/xgcc.exe -Bstage1/ -B/usr/local/i686-pc-cygwin/bin/   -g -O2 
-DIN_GCC   -W -Wall -Wwrite-strings -Wstrict-prototypes 
-Wmissing-prototypes -Wtraditional -pedantic -Wno-long-long 
-DHAVE_CONFIG_H   -DCYGWIN_CROSS_DIR=\"/usr/local/i686-pc-cygwin\" -I. 
-I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/config 
-I../../gcc/gcc/../include \
   -DSTANDARD_STARTFILE_PREFIX=\"../../../\" 
-DSTANDARD_EXEC_PREFIX=\"/usr/local/lib/gcc-lib/\" 
-DDEFAULT_TARGET_VERSION=\"3.3.4\" 
-DDEFAULT_TARGET_MACHINE=\"i686-pc-cygwin\" 
-DSTANDARD_BINDIR_PREFIX=\"/usr/local/bin/\" 
-DTOOLDIR_BASE_PREFIX=\"../../../../\"  `test "X${SHLIB_LINK}" = "X" || 
test "yes" != "yes" || echo "-DENABLE_SHARED_LIBGCC"` `test 
"X${SHLIB_MULTILIB}" = "X" || echo "-DNO_SHARED_LIBGCC_MULTILIB"` \
   -c ../../gcc/gcc/gcc.c -o gcc.o)
../../gcc/gcc/gcc.c:672: warning: traditional C rejects string concatenation
../../gcc/gcc/gcc.c:672: warning: string length `735' is greater than 
the length `509' ISO C89 compilers are required to support
../../gcc/gcc/gcc.c:679: warning: traditional C rejects string concatenation
../../gcc/gcc/gcc.c:683: warning: traditional C rejects string concatenation
../../gcc/gcc/gcc.c:706: warning: string length `524' is greater than 
the length `509' ISO C89 compilers are required to support
../../gcc/gcc/gcc.c:853: warning: string length `523' is greater than 
the length `509' ISO C89 compilers are required to support
In file included from specs.h:2,
                  from ../../gcc/gcc/gcc.c:883:
../../gcc/gcc/cp/lang-specs.h:45: warning: traditional C rejects string 
concatenation
../../gcc/gcc/cp/lang-specs.h:45: warning: string length `735' is 
greater than the length `509' ISO C89 compilers are required to support
In file included from specs.h:5,
                  from ../../gcc/gcc/gcc.c:883:
../../gcc/gcc/objc/lang-specs.h:28: warning: string length `546' is 
greater than the length `509' ISO C89 compilers are required to support
../../gcc/gcc/gcc.c:1437: warning: string length `733' is greater than 
the length `509' ISO C89 compilers are required to support
../../gcc/gcc/gcc.c: In function `process_command':
../../gcc/gcc/gcc.c:3609: error: assignment of read-only location
../../gcc/gcc/gcc.c:3611: error: assignment of read-only location
make[2]: *** [gcc.o] Error 1
make[2]: Leaving directory `/home/user/gcc/3.3/obj/gcc'
make[1]: *** [stage2_build] Error 2
make[1]: Leaving directory `/home/user/gcc/3.3/obj/gcc'
make: *** [bootstrap] Error 2

LAST_UPDATED
Wed Mar 24 20:30:30     2004
Wed Mar 24 19:30:30 GMT 2004

Anyone seeing this ?

--
Kind regards

Bauke

Re: [PR bootstrap/14356] Error building 3.3.4 on i686-cygwin.

[Kelley Cook]

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]

 > ../../gcc/gcc/gcc.c: In function `process_command':
 > ../../gcc/gcc/gcc.c:3609: error: assignment of read-only location
 > ../../gcc/gcc/gcc.c:3611: error: assignment of read-only location
 > make[2]: *** [gcc.o] Error 1

I hadn't tried CVS GCC 3.3 in a while, but I suspect that Mark 
Mitchell's patch to better diagnose constness was backported to GCC 3.3, 
which exposed a latent bug in gcc.c when it was ported to mainline and 3.4.

This became PR 14356

Anyway that was solved by: 
http://gcc.gnu.org/ml/gcc-patches/2004-03/msg00120.html which I would 
think should also now be backported to the GCC 3.3 branch.

Gaby,

Would this be OK if it passes an overnight bootstrap on i686-pc-cygwin?
It is different from Mark's patch as it had to be readjusted for K&R-ness.

Kelley Cook

[-- Attachment #2: gcc_const.patch --]
[-- Type: text/plain, Size: 1896 bytes --]

2004-03-24  Kelley Cook  <kcook@gcc.gnu.org>

	Backport:
	2004-03-01  Mark Mitchell  <mark@codesourcery.com>

	PR bootstrap/14356
	* gcc.c (process_command): Remove const-qualification from argv.
	(main): Likewise.

--- gcc.c.orig	2004-03-12 19:45:39.000000000 -0500
+++ gcc.c	2004-03-24 17:12:33.237528000 -0500
@@ -328,7 +328,7 @@ static void display_help 	PARAMS ((void)
 static void add_preprocessor_option	PARAMS ((const char *, int));
 static void add_assembler_option	PARAMS ((const char *, int));
 static void add_linker_option		PARAMS ((const char *, int));
-static void process_command		PARAMS ((int, const char *const *));
+static void process_command		PARAMS ((int, const char **));
 static int execute			PARAMS ((void));
 static void alloc_args			PARAMS ((void));
 static void clear_args			PARAMS ((void));
@@ -3050,7 +3050,7 @@ add_linker_option (option, len)
 static void
 process_command (argc, argv)
      int argc;
-     const char *const *argv;
+     const char **argv;
 {
   int i;
   const char *temp;
@@ -3279,10 +3279,10 @@ process_command (argc, argv)
     }
 
   /* Convert new-style -- options to old-style.  */
-  translate_options (&argc, &argv);
+  translate_options (&argc, (const char *const **) &argv);
 
   /* Do language-specific adjustment/addition of flags.  */
-  lang_specific_driver (&argc, &argv, &added_libraries);
+  lang_specific_driver (&argc, (const char *const **) &argv, &added_libraries);
 
   /* Scan argv twice.  Here, the first time, just count how many switches
      there will be in their vector, and how many input files in theirs.
@@ -5917,12 +5917,12 @@ fatal_error (signum)
   kill (getpid (), signum);
 }
 
-extern int main PARAMS ((int, const char *const *));
+extern int main PARAMS ((int, const char **));
 
 int
 main (argc, argv)
      int argc;
-     const char *const *argv;
+     const char **argv;
 {
   size_t i;
   int value;

Re: [PR bootstrap/14356] Error building 3.3.4 on i686-cygwin.

[Gabriel Dos Reis]

Kelley Cook <kcook34@ford.com> writes:

|  > ../../gcc/gcc/gcc.c: In function `process_command':
|  > ../../gcc/gcc/gcc.c:3609: error: assignment of read-only location
|  > ../../gcc/gcc/gcc.c:3611: error: assignment of read-only location
|  > make[2]: *** [gcc.o] Error 1
| 
| I hadn't tried CVS GCC 3.3 in a while, but I suspect that Mark
| Mitchell's patch to better diagnose constness was backported to GCC
| 3.3, which exposed a latent bug in gcc.c when it was ported to
| mainline and 3.4.
| 
| This became PR 14356
| 
| Anyway that was solved by:
| http://gcc.gnu.org/ml/gcc-patches/2004-03/msg00120.html which I would
| think should also now be backported to the GCC 3.3 branch.
| 
| Gaby,
| 
| Would this be OK if it passes an overnight bootstrap on i686-pc-cygwin?
| It is different from Mark's patch as it had to be readjusted for K&R-ness.

Yes, you have been quicker than me at looking at this (though day here).
Please apply it.

Thanks,

-- Gaby

Re: [PR bootstrap/14356] Error building 3.3.4 on i686-cygwin.

[Bauke van Dijk]

Kelley Cook wrote:

>  > ../../gcc/gcc/gcc.c: In function `process_command':
>  > ../../gcc/gcc/gcc.c:3609: error: assignment of read-only location
>  > ../../gcc/gcc/gcc.c:3611: error: assignment of read-only location
>  > make[2]: *** [gcc.o] Error 1
> 
> I hadn't tried CVS GCC 3.3 in a while, but I suspect that Mark 
> Mitchell's patch to better diagnose constness was backported to GCC 3.3, 
> which exposed a latent bug in gcc.c when it was ported to mainline and 3.4.
> 
> This became PR 14356
> 
> Anyway that was solved by: 
> http://gcc.gnu.org/ml/gcc-patches/2004-03/msg00120.html which I would 
> think should also now be backported to the GCC 3.3 branch.
> 
> Gaby,
> 
> Would this be OK if it passes an overnight bootstrap on i686-pc-cygwin?
> It is different from Mark's patch as it had to be readjusted for K&R-ness.
> 
> Kelley Cook
> 
> 
> ------------------------------------------------------------------------
> 
> 2004-03-24  Kelley Cook  <kcook@gcc.gnu.org>
> 
> 	Backport:
> 	2004-03-01  Mark Mitchell  <mark@codesourcery.com>
> 
> 	PR bootstrap/14356
> 	* gcc.c (process_command): Remove const-qualification from argv.
> 	(main): Likewise.
> 

Bootstrap passed, testsuite running.
Look good on my side.

Thanks

Bauke