From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22434 invoked by alias); 1 Apr 2004 08:29:16 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 22286 invoked from network); 1 Apr 2004 08:29:08 -0000 Received: from unknown (HELO ms-smtp-01.nyroc.rr.com) (24.24.2.55) by 67.72.78.213 with SMTP; 1 Apr 2004 08:29:08 -0000 Received: from twcny.rr.com (syr-24-59-116-209.twcny.rr.com [24.59.116.209]) by ms-smtp-01.nyroc.rr.com (8.12.10/8.12.10) with ESMTP id i318Sjri000099; Thu, 1 Apr 2004 03:28:45 -0500 (EST) Message-ID: <406BD2BD.4070300@twcny.rr.com> Date: Thu, 01 Apr 2004 08:29:00 -0000 From: Nathanael Nerode User-Agent: Mozilla Thunderbird 0.5 (X11/20040306) MIME-Version: 1.0 To: Jim Wilson CC: dj@redhat.com, gcc@gcc.gnu.org Subject: Re: No Subject References: <20040331044106.GA3560@twcny.rr.com> <1080715134.1059.83.camel@leaf.tuliptree.org> In-Reply-To: <1080715134.1059.83.camel@leaf.tuliptree.org> X-Enigmail-Version: 0.83.2.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Symantec AntiVirus Scan Engine X-SW-Source: 2004-04/txt/msg00008.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jim Wilson wrote: | On Tue, 2004-03-30 at 20:41, Nathanael Nerode wrote: | |>>I have a patch which tests for build!=host and disables WARN_CFLAGS, |>>but should fixinc *ever* be built with WARN_CFLAGS? |> |>No, it shouldn't. | | | I think this is an over simplistic answer. You really should be looking | more closely at this issue if you want to comment on it. | | With a native configure, BUILD_CFLAGS includes ALL_CFLAGS which includes | WARN_CFLAGS which includes GCC_WARN_CFLAGS which includes STRICT_WARN | and maybe also STRICT2_WARN. So clearly, the warning flags are used | when building fixinc in some cases, and that should not be broken. Oh, it's OK to use the warning flags for fixinc, but it's neither necessary nor terribly valuable -- I feel that they arrived essentially by accident. Long term, the plan was to put fixinc in its own top level directory. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFAa9K9RGZ0aC4lkIIRAmw9AJ9wG+CCfyrNXuC46rzP08nJXneLVgCeJIaw kTa+damTHIkbd11lwxfCeZQ= =2Qpm -----END PGP SIGNATURE-----