public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kean Johnston <jkj@sco.com>
To: Ian Lance Taylor <ian@airs.com>
Cc: gcc@gcc.gnu.org
Subject: Re: gcov weirdness: local lable being declared
Date: Sat, 30 Jul 2005 21:07:00 -0000	[thread overview]
Message-ID: <42EBEC12.1060100@sco.com> (raw)
In-Reply-To: <m3irys3v1b.fsf@gossamer.airs.com>

> I don't understand why the .type and .size information is useless.
Just some further information ... gas thinks it's useless too.

> The information is recorded in the object file.  I've seen various
No, it's not. At least not with gas 2.15.90.0.3. Just is just
silent about it. The SCO assembler is producing a warning because
if you have .type and .size for a sybol or lable for which
those things have no meaning, it warns you in case you meant
to do something else with the symbol. I believe the warning
message is valid.

In my original post, I asked if checking TREE_STATIC would be
the right thing. While it does shut the warning up, I don't think
it is. What we'd really need is some way to mark a tree as
internal. Then in coverage.c, mark the contructed variable
that way. For example, TREE_INTERNAL (gcov_info) = 1. The
only problem is that in order to do this, we would need to invent
a new bit in tree_common. Although there is an unused bit
available, I am not sure this has wide enough utility to
justify using it. But maybe it does. I leave it up to the
experts to decide.

An second solution would be to have create_coverage()
use a symbol name that isn't an internal lable. For example,
prefixing it with __gcov_. That also solves the problem.

A third alternatie would be to make A_D_O_N smarter,
and check to see if the first character of the name is
a period, and not eject the .size and .type if it is.

Anyone care to advise what the best course of action
would be? I'm leaning towards the second solution.

Kean

      parent reply	other threads:[~2005-07-30 21:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-30 17:15 Kean Johnston
2005-07-30 20:21 ` Ian Lance Taylor
2005-07-30 20:32   ` Kean Johnston
2005-07-31  0:31     ` Ian Lance Taylor
2005-07-30 21:07   ` Kean Johnston [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42EBEC12.1060100@sco.com \
    --to=jkj@sco.com \
    --cc=gcc@gcc.gnu.org \
    --cc=ian@airs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).