From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21814 invoked by alias); 19 Jun 2008 22:08:41 -0000 Received: (qmail 21795 invoked by uid 22791); 19 Jun 2008 22:08:40 -0000 X-Spam-Check-By: sourceware.org Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.171) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 19 Jun 2008 22:08:05 +0000 Received: by ug-out-1314.google.com with SMTP id m2so1067648ugc.17 for ; Thu, 19 Jun 2008 15:08:02 -0700 (PDT) Received: by 10.210.19.11 with SMTP id 11mr2377096ebs.111.1213913282260; Thu, 19 Jun 2008 15:08:02 -0700 (PDT) Received: by 10.210.52.6 with HTTP; Thu, 19 Jun 2008 15:08:02 -0700 (PDT) Message-ID: <4348dea50806191508h5743306au65de2d06d7f13d5a@mail.gmail.com> Date: Thu, 19 Jun 2008 22:08:00 -0000 From: "Jonathan Wakely" To: "Mark Mitchell" Subject: Re: C++ warnings vs. errors Cc: gcc-patches , gcc@gcc.gnu.org, "Volker Reichelt" , "=?ISO-8859-1?Q?Manuel_L=F3pez-Ib=E1=F1ez?=" In-Reply-To: <4859657A.6060500@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4348dea50806111605m597a6df7qd54ffe71e5b12bbb@mail.gmail.com> <4348dea50806171247v3573f5a0q481846234594b3ae@mail.gmail.com> <4859657A.6060500@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2008-06/txt/msg00467.txt.bz2 2008/6/18 Mark Mitchell: >> * I don't think the pedwarn in joust() in cp/call.c should be a >> permerror, is this a GNU extension? >> if (warn) >> { >> pedwarn ("\ >> ISO C++ says that these are ambiguous, even \ >> though the worst conversion for the first is better than \ >> the worst conversion for the second:"); >> print_z_candidate (_("candidate 1:"), w); >> print_z_candidate (_("candidate 2:"), l); >> } > > Yes, that is a historical GNU extension. I think this should just be a > warning, given that the whole section of code is guarded with !pedantic. OK. Should I also get rid of the escaped newlines and rely on string concatenation for the text? Jon >> * I don't know if these in cp/typeck.c should be permerrors, DTRT >> implies not, but should tf_error be changed to tf_warning? > > I think "DTRT" here means "do what whoever wrote this code thinks the > standard should say" not "do what the standard says". Please make these > permerrors. > > Thanks, > > -- > Mark Mitchell > CodeSourcery > mark@codesourcery.com > (650) 331-3385 x713 > >