From: Daniel Berlin <dberlin@dberlin.org>
To: Andrew Pinski <pinskia@physics.uc.edu>
Cc: gcc@gcc.gnu.org, Dorit Naishlos <DORIT@il.ibm.com>,
Devang Patel <dpatel@apple.com>
Subject: Re: [lno] [RFC] if-conversion and auto vectorizer
Date: Sun, 14 Mar 2004 22:31:00 -0000 [thread overview]
Message-ID: <43E0DC1C-7607-11D8-A8CC-000A95DA505C@dberlin.org> (raw)
In-Reply-To: <F8DDB6DE-75EC-11D8-8086-000393A6D2F2@physics.uc.edu>
On Mar 14, 2004, at 2:22 PM, Andrew Pinski wrote:
>
> On Mar 14, 2004, at 03:07, Dorit Naishlos wrote:
>
>>> I will also be doing the following soon (after MIN/MAX becomes gimple
>>> which has already be discussed and approved):
>>
>> I seem to have missed the MIN/MAX discussion thread. Do you have a
>> link to
>> that, or was it off the mailing list? just curious when is it planned
>> to
>> add the MIN/MAX tree codes to gimple and who is responsible for that?
>
> It was discussed off list (on IRC). Really MIN/MAX is already gimple,
> just that it gets
> lowered when gimplifing happens. Also right now DOM does not
> understand MIN/MAX.
> The current plan is remove the lowering when the tree-ssa gets merged
> into the mainline.
> I think Daniel Berlin said he would be the one to remove the lowering
> as the linear loop
> transformation generates better code with MIN/MAX instead of different
> basic blocks.
It's not better code so much as much less complex code. This is in the
case of integer min/max.
Otherwise, performing a min/max requires 1 cond_expr, two new basic
blocks, two new labels, and two new gotos, per MAX/MIN operation.
In the case of floating point min/max, RTH pointed out that it is very
hard to put the lowered form back together into MAX/MIN.
> I think he also has a patch to teach DOM about it too but I am not too
> sure.
>
There isn't really much to teach DOM about here.
Previously, DOM saw
if (a < b)
c = a;
else
c = b;
It knew that in each arm, a was either < or > b, respectively.
With
c = MAX (a, b);
we know nothing about each arm (because they are implicit), but it
doesn't actually matter, because you couldn't have done anything with
the info anyway here.
So i'm not sure what you want me to teach DOM.
next prev parent reply other threads:[~2004-03-14 22:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-14 10:57 Fw: " Dorit Naishlos
2004-03-14 19:22 ` Andrew Pinski
2004-03-14 22:31 ` Daniel Berlin [this message]
2004-03-15 2:29 ` Alex Rosenberg
2004-03-15 22:38 ` Richard Henderson
2004-03-15 23:08 ` Devang Patel
2004-03-15 23:20 ` Richard Henderson
2004-03-16 0:02 ` Devang Patel
2004-03-16 0:07 ` Diego Novillo
2004-03-16 0:45 ` Richard Henderson
2004-03-16 3:02 ` Diego Novillo
2004-03-16 3:33 ` Richard Henderson
2004-03-16 6:33 ` Devang Patel
-- strict thread matches above, loose matches on Subject: below --
2004-03-16 12:27 Robert Dewar
2004-03-16 18:32 ` Richard Henderson
2004-03-16 22:51 ` Toon Moene
2004-03-16 23:10 ` Joseph S. Myers
2004-03-16 23:28 ` Toon Moene
2004-03-16 23:37 ` Richard Henderson
2004-03-16 23:42 ` Toon Moene
2004-03-16 5:33 Robert Dewar
2004-03-16 6:54 ` Richard Henderson
2004-03-16 3:46 Chris Lattner
2004-03-15 22:42 Robert Dewar
2004-03-15 23:08 ` Richard Henderson
2004-03-04 19:59 Devang Patel
2004-03-04 20:12 ` Andrew Pinski
2004-03-04 20:39 ` Devang Patel
2004-03-04 21:03 ` Richard Henderson
2004-03-05 19:06 ` Devang Patel
2004-03-05 19:17 ` Diego Novillo
2004-03-05 19:22 ` Diego Novillo
2004-03-05 19:28 ` Devang Patel
2004-03-05 19:41 ` Diego Novillo
2004-03-05 19:44 ` Diego Novillo
2004-03-12 18:45 ` Devang Patel
2004-03-13 9:24 ` Zdenek Dvorak
2004-03-13 22:41 ` Devang Patel
2004-03-14 10:59 ` Dorit Naishlos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43E0DC1C-7607-11D8-A8CC-000A95DA505C@dberlin.org \
--to=dberlin@dberlin.org \
--cc=DORIT@il.ibm.com \
--cc=dpatel@apple.com \
--cc=gcc@gcc.gnu.org \
--cc=pinskia@physics.uc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).