From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 2BCB73858438 for ; Thu, 8 Jun 2023 17:59:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2BCB73858438 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-510f866ce78so199468a12.1 for ; Thu, 08 Jun 2023 10:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686247166; x=1688839166; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Zi/6qNaUKTR/BmYpw/JCrWcl+Qgdod/Zn8CydXeKa5U=; b=iKA4dqNgLmW7H8e0DG6EXiq09OQ4BGAjvS56HEOT5T26WzuYp92z/7Ws1X781jV1io TZTa/1Z+bLBqq2v2AIi7iCYQmJzlVDBK3fmoUr418cDllZUOYDBSym0ukTa8ZEAtbX20 nRHGWDtPrRRGDf+uGAAyRnvSX/GQVGKY4aGMLxhKwusXwM1R7aviqSeWy4YawPl9oz2C y8jmIjhanLjnZSkZE+R8ws7JGE5DvcBzOnfxWmwxrANVC7pww//vjiMcqDrg1knN0hxN 9cbrdB0XoBDiSQgHvMK51xrMXjZInPwkeqiTTyTCQP7E4oKB+AUA0V4wwRslg72rqJpx Sz+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686247166; x=1688839166; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zi/6qNaUKTR/BmYpw/JCrWcl+Qgdod/Zn8CydXeKa5U=; b=T1x7RL9MRDWfQHyD08NQFLqSKZCH3gb6EIH/ngVD7skjYkJ75Ae5YuWCNvy5WfQ9Ch EDK1OsNbT+wuKa6ORaYphVyqIuzeqr1PR+Wb5RxdZZiASQBmSUaZceZNSAiT0RVulb00 7h40BaFFszKTnvZBwKmBlrUfFpvlLDisJN3aSYGIr7PXn520zeSqk1FHD4AZKm0/sLVC HpqfSoNw9+ls0APesKKe8cgV7F164s2XdEKH1ENjLvT9xC5VS3/d3xeVF8Du72jXMdDu 952AYoM9ybuNJrPfBiVFREhK8dW0+qK3EDdJhrL5NYzi4HIyw5DSxtI4SsuNRIVhoA3y fOtQ== X-Gm-Message-State: AC+VfDzQShYPW23NPT//cpwrQ2ccGzWYhd5R+fMwlQUFn7NxWe7XrE3X DK3lPZNve8vkzmdPN5UQEF9I X-Google-Smtp-Source: ACHHUZ5vHIaRfq6VEltunmhEAmHf/98izpPanZKMT+KSsyLa3i0bBLQOs2l5AQ/QSHov8Ru2z13mGw== X-Received: by 2002:a05:6402:524e:b0:50c:79f:c693 with SMTP id t14-20020a056402524e00b0050c079fc693mr3373643edd.1.1686247165732; Thu, 08 Jun 2023 10:59:25 -0700 (PDT) Received: from smtpclient.apple ([2a00:cc47:21fb:f100:5c7:9e40:49bd:38e7]) by smtp.gmail.com with ESMTPSA id f9-20020a056402068900b0051495ce23absm796859edy.10.2023.06.08.10.59.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Jun 2023 10:59:24 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: [PATCH v6 0/4] P1689R5 support From: Maxim Kuvyrkov In-Reply-To: <20230606205025.3164738-1-ben.boeckel@kitware.com> Date: Thu, 8 Jun 2023 21:59:13 +0400 Cc: gcc-patches , Jason Merrill , nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com Content-Transfer-Encoding: quoted-printable Message-Id: <444B887D-CA74-47EF-AD02-F17D000FE9A4@linaro.org> References: <20230606205025.3164738-1-ben.boeckel@kitware.com> To: Ben Boeckel X-Mailer: Apple Mail (2.3731.500.231) X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Jun 7, 2023, at 00:50, Ben Boeckel via Gcc-patches = wrote: >=20 > Hi, >=20 > This patch series adds initial support for ISO C++'s [P1689R5][], a > format for describing C++ module requirements and provisions based on > the source code. This is required because compiling C++ with modules = is > not embarrassingly parallel and need to be ordered to ensure that > `import some_module;` can be satisfied in time by making sure that any > TU with `export import some_module;` is compiled first. Hi Ben, This patch series causes ICEs on arm-linux-gnueabihf. Would you please = investigate? Please let me know if you need any in reproducing these. =3D=3D=3D g++ tests =3D=3D=3D Running g++:g++.dg/modules/modules.exp ... FAIL: g++.dg/modules/ben-1_a.C -std=3Dc++17 (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/ben-1_a.C -std=3Dc++17 (test for excess errors) FAIL: g++.dg/modules/ben-1_a.C -std=3Dc++2a (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/ben-1_a.C -std=3Dc++2a (test for excess errors) FAIL: g++.dg/modules/ben-1_a.C -std=3Dc++2b (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/ben-1_a.C -std=3Dc++2b (test for excess errors) FAIL: g++.dg/modules/ben-1_a.C module-cmi =3Dpartitions/module-import.mod = (partitions/module-import.mod) FAIL: g++.dg/modules/ben-1_b.C -std=3Dc++17 (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/ben-1_b.C -std=3Dc++17 (test for excess errors) FAIL: g++.dg/modules/ben-1_b.C -std=3Dc++2a (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/ben-1_b.C -std=3Dc++2a (test for excess errors) FAIL: g++.dg/modules/ben-1_b.C -std=3Dc++2b (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/ben-1_b.C -std=3Dc++2b (test for excess errors) FAIL: g++.dg/modules/ben-1_b.C module-cmi =3Dmodule.mod (module.mod) FAIL: g++.dg/modules/gc-2_a.C -std=3Dc++17 (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/gc-2_a.C -std=3Dc++17 (test for excess errors) FAIL: g++.dg/modules/gc-2_a.C -std=3Dc++2a (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/gc-2_a.C -std=3Dc++2a (test for excess errors) FAIL: g++.dg/modules/gc-2_a.C -std=3Dc++2b (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/gc-2_a.C -std=3Dc++2b (test for excess errors) FAIL: g++.dg/modules/gc-2_a.C module-cmi =3Dmap-1_a.nms (map-1_a.nms) UNRESOLVED: g++.dg/modules/map-1 -std=3Dc++17 execute UNRESOLVED: g++.dg/modules/map-1 -std=3Dc++17 link UNRESOLVED: g++.dg/modules/map-1 -std=3Dc++2a execute UNRESOLVED: g++.dg/modules/map-1 -std=3Dc++2a link UNRESOLVED: g++.dg/modules/map-1 -std=3Dc++2b execute UNRESOLVED: g++.dg/modules/map-1 -std=3Dc++2b link FAIL: g++.dg/modules/map-1_a.C -std=3Dc++17 (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/map-1_a.C -std=3Dc++17 (test for excess errors) FAIL: g++.dg/modules/map-1_a.C -std=3Dc++2a (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/map-1_a.C -std=3Dc++2a (test for excess errors) FAIL: g++.dg/modules/map-1_a.C -std=3Dc++2b (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/map-1_a.C -std=3Dc++2b (test for excess errors) FAIL: g++.dg/modules/map-1_a.C module-cmi =3Dmap-1_a.nms (map-1_a.nms) FAIL: g++.dg/modules/map-1_b.C -std=3Dc++17 (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/map-1_b.C -std=3Dc++17 (test for excess errors) FAIL: g++.dg/modules/map-1_b.C -std=3Dc++2a (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/map-1_b.C -std=3Dc++2a (test for excess errors) FAIL: g++.dg/modules/map-1_b.C -std=3Dc++2b (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/map-1_b.C -std=3Dc++2b (test for excess errors) FAIL: g++.dg/modules/map-2.C -std=3Dc++17 at line 8 (test for errors, = line 7) FAIL: g++.dg/modules/map-2.C -std=3Dc++17 at line 9 (test for errors, = line ) FAIL: g++.dg/modules/map-2.C -std=3Dc++17 (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/map-2.C -std=3Dc++17 (test for excess errors) FAIL: g++.dg/modules/map-2.C -std=3Dc++2a at line 8 (test for errors, = line 7) FAIL: g++.dg/modules/map-2.C -std=3Dc++2a at line 9 (test for errors, = line ) FAIL: g++.dg/modules/map-2.C -std=3Dc++2a (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/map-2.C -std=3Dc++2a (test for excess errors) FAIL: g++.dg/modules/map-2.C -std=3Dc++2b at line 8 (test for errors, = line 7) FAIL: g++.dg/modules/map-2.C -std=3Dc++2b at line 9 (test for errors, = line ) FAIL: g++.dg/modules/map-2.C -std=3Dc++2b (internal compiler error: = Segmentation fault) FAIL: g++.dg/modules/map-2.C -std=3Dc++2b (test for excess errors) =3D=3D=3D Thanks, -- Maxim Kuvyrkov https://www.linaro.org >=20 > [P1689R5]: https://isocpp.org/files/papers/P1689R5.html >=20 > I've also added patches to include imported module CMI files and the > module mapper file as dependencies of the compilation. I briefly = looked > into adding dependencies on response files as well, but that appeared = to > need some code contortions to have a `class mkdeps` available before > parsing the command line or to keep the information around until one = was > made. >=20 > I'd like feedback on the approach taken here with respect to the > user-visible flags. I'll also note that header units are not supported > at this time because the current `-E` behavior with respect to `import > ;` is to search for an appropriate `.gcm` file which is = not > something such a "scan" can support. A new mode will likely need to be > created (e.g., replacing `-E` with `-fc++-module-scanning` or = something) > where headers are looked up "normally" and processed only as much as > scanning requires. >=20 > FWIW, Clang as taken an alternate approach with its `clang-scan-deps` > tool rather than using the compiler directly. >=20 > Thanks, >=20 > --Ben >=20 > --- > v5 -> v6: >=20 > - rebase onto `master` (585c660f041 (reload1: Change return type of > predicate function from int to bool, 2023-06-06)) > - fix crash related to reporting imported CMI files as dependencies > - rework utf-8 validity to patch the new `cpp_valid_utf8_p` function > instead of the core utf-8 decoding routine to reject invalid > codepoints (preserves higher-level error detection of invalid utf-8) > - harmonize of `fdeps` spelling in flags, variables, comments, etc. > - rename `-fdeps-output=3D` to `-fdeps-target=3D` >=20 > v4 -> v5: >=20 > - add dependency tracking for imported modules to `-MF` > - add dependency tracking for static module mapper files given to > `-fmodule-mapper=3D` >=20 > v3 -> v4: >=20 > - add missing spaces between function names and arguments >=20 > v2 -> v3: >=20 > - changelog entries moved to commit messages > - documentation updated/added in the UTF-8 routine editing >=20 > v1 -> v2: >=20 > - removal of the `deps_write(extra)` parameter to option-checking = where > ndeeded > - default parameter of `cpp_finish(fdeps_stream =3D NULL)` > - unification of libcpp UTF-8 validity functions from v1 > - test cases for flag parsing states (depflags-*) and p1689 output > (p1689-*) >=20 > Ben Boeckel (4): > libcpp: reject codepoints above 0x10FFFF > p1689r5: initial support > c++modules: report imported CMI files as dependencies > c++modules: report module mapper files as a dependency >=20 > gcc/c-family/c-opts.cc | 40 +++- > gcc/c-family/c.opt | 12 + > gcc/cp/mapper-client.cc | 4 + > gcc/cp/mapper-client.h | 1 + > gcc/cp/module.cc | 24 +- > gcc/doc/invoke.texi | 15 ++ > gcc/testsuite/g++.dg/modules/depflags-f-MD.C | 2 + > gcc/testsuite/g++.dg/modules/depflags-f.C | 1 + > gcc/testsuite/g++.dg/modules/depflags-fi.C | 3 + > gcc/testsuite/g++.dg/modules/depflags-fj-MD.C | 3 + > gcc/testsuite/g++.dg/modules/depflags-fj.C | 4 + > .../g++.dg/modules/depflags-fjo-MD.C | 4 + > gcc/testsuite/g++.dg/modules/depflags-fjo.C | 5 + > gcc/testsuite/g++.dg/modules/depflags-fo-MD.C | 3 + > gcc/testsuite/g++.dg/modules/depflags-fo.C | 4 + > gcc/testsuite/g++.dg/modules/depflags-j-MD.C | 2 + > gcc/testsuite/g++.dg/modules/depflags-j.C | 3 + > gcc/testsuite/g++.dg/modules/depflags-jo-MD.C | 3 + > gcc/testsuite/g++.dg/modules/depflags-jo.C | 4 + > gcc/testsuite/g++.dg/modules/depflags-o-MD.C | 2 + > gcc/testsuite/g++.dg/modules/depflags-o.C | 3 + > gcc/testsuite/g++.dg/modules/modules.exp | 1 + > gcc/testsuite/g++.dg/modules/p1689-1.C | 18 ++ > gcc/testsuite/g++.dg/modules/p1689-1.exp.json | 27 +++ > gcc/testsuite/g++.dg/modules/p1689-2.C | 16 ++ > gcc/testsuite/g++.dg/modules/p1689-2.exp.json | 16 ++ > gcc/testsuite/g++.dg/modules/p1689-3.C | 14 ++ > gcc/testsuite/g++.dg/modules/p1689-3.exp.json | 16 ++ > gcc/testsuite/g++.dg/modules/p1689-4.C | 14 ++ > gcc/testsuite/g++.dg/modules/p1689-4.exp.json | 14 ++ > gcc/testsuite/g++.dg/modules/p1689-5.C | 14 ++ > gcc/testsuite/g++.dg/modules/p1689-5.exp.json | 14 ++ > gcc/testsuite/g++.dg/modules/test-p1689.py | 222 ++++++++++++++++++ > gcc/testsuite/lib/modules.exp | 71 ++++++ > libcpp/charset.cc | 7 + > libcpp/include/cpplib.h | 12 +- > libcpp/include/mkdeps.h | 17 +- > libcpp/init.cc | 13 +- > libcpp/mkdeps.cc | 149 +++++++++++- > 39 files changed, 769 insertions(+), 28 deletions(-) > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-f-MD.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-f.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fi.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fj-MD.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fj.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fjo-MD.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fjo.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fo-MD.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-fo.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-j-MD.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-j.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-jo-MD.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-jo.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-o-MD.C > create mode 100644 gcc/testsuite/g++.dg/modules/depflags-o.C > create mode 100644 gcc/testsuite/g++.dg/modules/p1689-1.C > create mode 100644 gcc/testsuite/g++.dg/modules/p1689-1.exp.json > create mode 100644 gcc/testsuite/g++.dg/modules/p1689-2.C > create mode 100644 gcc/testsuite/g++.dg/modules/p1689-2.exp.json > create mode 100644 gcc/testsuite/g++.dg/modules/p1689-3.C > create mode 100644 gcc/testsuite/g++.dg/modules/p1689-3.exp.json > create mode 100644 gcc/testsuite/g++.dg/modules/p1689-4.C > create mode 100644 gcc/testsuite/g++.dg/modules/p1689-4.exp.json > create mode 100644 gcc/testsuite/g++.dg/modules/p1689-5.C > create mode 100644 gcc/testsuite/g++.dg/modules/p1689-5.exp.json > create mode 100644 gcc/testsuite/g++.dg/modules/test-p1689.py > create mode 100644 gcc/testsuite/lib/modules.exp >=20 >=20 > base-commit: 585c660f041c57694a61b3e65085af5a54431be4 > --=20 > 2.40.1 >=20