From: Jeffrey A Law <law@cygnus.com>
To: Carlo Wood <carlo@runaway.xs4all.nl>
Cc: egcs@cygnus.com (egcs@cygnus.com)
Subject: Re: The "980505-1.c" bug (The Story Continued)
Date: Sat, 11 Jul 1998 00:17:00 -0000 [thread overview]
Message-ID: <4673.900135814@hurl.cygnus.com> (raw)
In-Reply-To: <199807100056.CAA11845@jolan.ppro>
You're missing a critical piece of understanding.
The references to (reg 23) in the notes of the RETVAL insn are wrong
once CSE changes the code in the libcall block to use the constant
instead of (reg 23) as an argument.
The notes should have been modified during the first CSE pass to refer
to the real arguments used in the libcall sequence.
This is what my patch fixed. The notes in the RETVAL insn are updated
at the same time as the instructions in the libcall sequence itself are
updated.
You briefly touched on this in one of your messages:
The solution that would lead to the best optimisation is by making sure that
the expression list of the call is correct: The constants are put directly
on the stack, so the expression list should say THAT, and not say that register
23 was used.
This is exactly what my patch does.
--
jeff
prev parent reply other threads:[~1998-07-11 0:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-07-09 19:08 Carlo Wood
1998-07-10 22:59 ` Jeffrey A Law
1998-07-10 23:00 ` Carlo Wood
1998-07-10 23:00 ` Jeffrey A Law
1998-07-11 12:10 ` Carlo Wood
1998-07-11 0:17 ` Jeffrey A Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4673.900135814@hurl.cygnus.com \
--to=law@cygnus.com \
--cc=carlo@runaway.xs4all.nl \
--cc=egcs@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).