From: Paolo Bonzini <bonzini@gnu.org>
To: Andreas Schwab <schwab@suse.de>
Cc: Ian Lance Taylor <iant@google.com>,
Doug Gregor <doug.gregor@gmail.com>,
jklowden@freetds.org, gcc-patches@gcc.gnu.org, gcc@gnu.org
Subject: Re: -Wparentheses lumps too much together
Date: Sat, 12 Jan 2008 11:23:00 -0000 [thread overview]
Message-ID: <4788954D.6010304@gnu.org> (raw)
In-Reply-To: <jezlvbmlps.fsf@sykes.suse.de>
Andreas Schwab wrote:
> Ian Lance Taylor <iant@google.com> writes:
>
>> I'm inclined to approve this if -Wprecedence stays in -Wall, but I'd
>> like to hear if anybody else has anything to say.
>
> The name of the option is rather poor, IMHO. -Wparentheses warns about
> precedences, so what is the difference to -Wprecedence?
-Wparentheses warns in general about things that the GCS prefer to be
parenthesized. I would prefer something like
int warn_precedence = 2;
...
if (warn_precedence == 2)
warn_precedence = warn_parentheses;
that is, we have
-Wparentheses remains as is now, and is enabled by -Wall
-Wparentheses -Wno-precedence only warns about things like a = b = c
for bool b and non-bool a
Paolo
next prev parent reply other threads:[~2008-01-12 10:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 20:07 jklowden
2007-12-19 20:14 ` Doug Gregor
2007-12-19 20:39 ` Ismail Dönmez
2007-12-19 20:15 ` Daniel Jacobowitz
2007-12-19 23:11 ` Ian Lance Taylor
2007-12-20 6:08 ` James K. Lowden
2007-12-20 16:41 ` Paul Brook
2007-12-21 20:19 ` Ross Smith
2008-01-11 7:34 ` Rehno Lindeque
2008-01-11 17:00 ` Joe Buck
2008-01-11 17:05 ` Robert Dewar
2008-01-11 23:26 ` Ian Lance Taylor
2008-01-12 0:50 ` Joe Buck
2007-12-20 18:01 ` Ian Lance Taylor
2007-12-21 5:28 ` James K. Lowden
2007-12-21 9:27 ` Ralf Wildenhues
2007-12-21 17:16 ` NightStrike
2008-01-11 22:44 ` Doug Gregor
2008-01-12 3:48 ` Ian Lance Taylor
2008-01-12 10:16 ` Andreas Schwab
2008-01-12 11:23 ` Paolo Bonzini [this message]
2008-01-13 16:03 ` Gabriel Dos Reis
2008-03-10 17:25 Derek M Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4788954D.6010304@gnu.org \
--to=bonzini@gnu.org \
--cc=doug.gregor@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gnu.org \
--cc=iant@google.com \
--cc=jklowden@freetds.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).